Skip to content

Commit

Permalink
[BUGFIX] Fix missing closing divs in SelectSingleBoxElement
Browse files Browse the repository at this point in the history
Under certain conditions closing divs were missing:

1. When all fieldControls are disabled.
2. If the field itself is disabled.

This fixes these cases, so we have correct html at all times.

Resolves: #94535
Releases: master, 10.4
Change-Id: Ieb7670666b6a927e80eb7377770d7f54189bc093
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69808
Tested-by: core-ci <typo3@b13.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
  • Loading branch information
nhovratov authored and bmack committed Jul 12, 2021
1 parent 35f272f commit 843c14c
Showing 1 changed file with 3 additions and 1 deletion.
Expand Up @@ -139,8 +139,8 @@ public function render()
$html[] = '<div class="form-wizards-items-aside">';
$html[] = $fieldControlHtml;
$html[] = '</div>';
$html[] = '</div>';
}
$html[] = '</div>'; // Close form-wizards-aside
$html[] = '<p>';
$html[] = '<em>' . htmlspecialchars($languageService->sL('LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.holdDownCTRL')) . '</em>';
$html[] = '</p>';
Expand All @@ -149,6 +149,8 @@ public function render()
$html[] = $fieldWizardHtml;
$html[] = '</div>';
}
} else {
$html[] = '</div>'; // Close form-wizards-aside
}
$html[] = '</div>';
$html[] = '</div>';
Expand Down

0 comments on commit 843c14c

Please sign in to comment.