Skip to content

Commit

Permalink
[TASK] Drop a "probably not required" method from routing
Browse files Browse the repository at this point in the history
Method addArguments() of Route class is marked as
'@deprecated Probably not required'. It looks like
a left over from the routing development. The method is
indeed unused and can be dropped without further
notice from this @internal marked class.

Change-Id: Iefaec031003b55571c5d2f0f658fed9b25132cbb
Resolves: #87488
Releases: master.
Reviewed-on: https://review.typo3.org/59486
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
  • Loading branch information
lolli42 authored and wouter90 committed Jan 18, 2019
1 parent 472ed7d commit 9bbe310
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions typo3/sysext/core/Classes/Routing/Route.php
Expand Up @@ -64,25 +64,6 @@ public function getArguments(): array
return $this->getOption('_arguments') ?? [];
}

/**
* @param array $arguments
* @deprecated Probably not required
*/
public function addArguments(array $arguments)
{
$mergedArguments = $this->getArguments();
foreach ($arguments as $key => $argument) {
if (isset($mergedArguments[$key])) {
throw new \OverflowException(
sprintf('Cannot override argument %s', $key),
1538326790
);
}
$mergedArguments[$key] = $argument;
}
$this->setOption('_arguments', $mergedArguments);
}

/**
* @return EnhancerInterface|null
*/
Expand Down

0 comments on commit 9bbe310

Please sign in to comment.