[TASK] Use DI for LoadTcaService in UpgradeController

Resolves: #106714
Releases: main, 13.4
Change-Id: I2d0e18f631c9bd37f60b1d305b69ae9f44168f60
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/89433
Tested-by: Oli Bartsch <bo@cedev.de>
Reviewed-by: Oli Bartsch <bo@cedev.de>
Tested-by: core-ci <typo3@b13.com>

Author: o-ba

typo3/sysext/install/Classes/Controller/UpgradeController.php

@@ -852,8 +852,7 @@ public function tcaExtTablesCheckAction(ServerRequestInterface $request): Respon
     {
         $view = $this->initializeView($request);
         $messageQueue = new FlashMessageQueue('install');
-        $loadTcaService = GeneralUtility::makeInstance(LoadTcaService::class);
-        $loadTcaService->loadExtensionTablesWithoutMigration();
+        $this->loadTcaService->loadExtensionTablesWithoutMigration();
         $baseTca = $GLOBALS['TCA'];
         $container = $this->lateBootService->getContainer();
         $backup = $this->lateBootService->makeCurrent($container);
@@ -863,7 +862,7 @@ public function tcaExtTablesCheckAction(ServerRequestInterface $request): Respon
             $extensionKey = $package->getPackageKey();
             $extTablesPath = $package->getPackagePath() . 'ext_tables.php';
             if (@file_exists($extTablesPath)) {
-                $loadTcaService->loadSingleExtTablesFile($extensionKey);
+                $this->loadTcaService->loadSingleExtTablesFile($extensionKey);
                 $newTca = $GLOBALS['TCA'];
                 if ($newTca !== $baseTca) {
                     $messageQueue->enqueue(new FlashMessage(
@@ -896,7 +895,7 @@ public function tcaMigrationsCheckAction(ServerRequestInterface $request): Respo
     {
         $view = $this->initializeView($request);
         $messageQueue = new FlashMessageQueue('install');
-        GeneralUtility::makeInstance(LoadTcaService::class)->loadExtensionTablesWithoutMigration();
+        $this->loadTcaService->loadExtensionTablesWithoutMigration();
         $tcaMigration = GeneralUtility::makeInstance(TcaMigration::class);
         $GLOBALS['TCA'] = $tcaMigration->migrate($GLOBALS['TCA']);
         $tcaMessages = $tcaMigration->getMessages();