Skip to content

Conversation

@kongdd
Copy link
Contributor

@kongdd kongdd commented Nov 6, 2025

I am submitting

  • a new package
  • an update for a package

Description: Explain what the package does and why it's useful.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@typst-package-check typst-package-check bot changed the title modern-cug-report v0.1.3 modern-cug-report:0.1.3 Nov 6, 2025
@typst-package-check typst-package-check bot added the update A package update. label Nov 6, 2025
@kongdd
Copy link
Contributor Author

kongdd commented Nov 6, 2025

All warnings has been eliminated, except the following two in another package, mitex:

2 warnings
Our bots have automatically run some checks on your packages. They found 0 errors and 2 warnings.

Warnings are suggestions, your package can still be accepted even if you prefer not to fix them.

A human being will soon review your package, too.

Annotations
 [Check warning on line 1045 in packages/preview/mitex/0.2.5/specs/latex/standard.typ](https://github.com/typst/packages/pull/3407/files#annotation_41228296408) 

@typst-package-check
typst-package-check
/ @preview/modern-cug-report:0.1.3
packages/preview/mitex/0.2.5/specs/latex/standard.typ#L1045

The following warning was reported by the Typst compiler: `kai` is deprecated, use ϗ or `\u{3d7}` instead

Hope this version can be accepted.

@elegaanz elegaanz self-assigned this Nov 6, 2025
Copy link
Member

@elegaanz elegaanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MiTeX warning is fine, since the symbol will be removed in the next Typst version, which should not be published very soon. However I would appreciate if you could publish a new version to update this dependency once they have fixed the issue on their side. Maybe the issue should also be reported upstream if not already done.


<!-- ![](./thumbnail.png) -->

![](./example/ch03_1.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a short image description to these examples, in case the image can't load because of a poor internet connection, or for screen reader users. Also, it seems that your example images have no background fill, which means they will render poorly for dark theme users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your careful review. I revise now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be improved now

@kongdd
Copy link
Contributor Author

kongdd commented Nov 12, 2025

This pr should be ready to go. Thanks

@kongdd
Copy link
Contributor Author

kongdd commented Nov 12, 2025

Just wondering whether it is possible to move example directory to the parent directory.

There are some figures in example. It usually has no change in each update.

@elegaanz
Copy link
Member

Unfortunately that's not possible, no. It would make the bundling logic more complicated.

@elegaanz elegaanz merged commit 8884c5f into typst:main Nov 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update A package update.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants