-
Notifications
You must be signed in to change notification settings - Fork 799
modern-cug-report:0.1.3 #3407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modern-cug-report:0.1.3 #3407
Conversation
|
All warnings has been eliminated, except the following two in another package, 2 warnings
Our bots have automatically run some checks on your packages. They found 0 errors and 2 warnings.
Warnings are suggestions, your package can still be accepted even if you prefer not to fix them.
A human being will soon review your package, too.
Annotations
[Check warning on line 1045 in packages/preview/mitex/0.2.5/specs/latex/standard.typ](https://github.com/typst/packages/pull/3407/files#annotation_41228296408)
@typst-package-check
typst-package-check
/ @preview/modern-cug-report:0.1.3
packages/preview/mitex/0.2.5/specs/latex/standard.typ#L1045
The following warning was reported by the Typst compiler: `kai` is deprecated, use ϗ or `\u{3d7}` insteadHope this version can be accepted. |
elegaanz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MiTeX warning is fine, since the symbol will be removed in the next Typst version, which should not be published very soon. However I would appreciate if you could publish a new version to update this dependency once they have fixed the issue on their side. Maybe the issue should also be reported upstream if not already done.
|
|
||
| <!--  --> | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add a short image description to these examples, in case the image can't load because of a poor internet connection, or for screen reader users. Also, it seems that your example images have no background fill, which means they will render poorly for dark theme users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your careful review. I revise now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be improved now
|
This pr should be ready to go. Thanks |
|
Just wondering whether it is possible to move example directory to the parent directory. There are some figures in example. It usually has no change in each update. |
|
Unfortunately that's not possible, no. It would make the bundling logic more complicated. |
I am submitting
Description: Explain what the package does and why it's useful.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE