Added to-absolute method to length.#3117
Merged
Merged
Conversation
laurmaedje
reviewed
Jan 2, 2024
laurmaedje
left a comment
Member
There was a problem hiding this comment.
I'm okay with adding this, but think we should discuss the name a bit. resolve is quite generic. Maybe we can find a name that describes more concretely what is happening.
Contributor
|
|
resolve method to length.to-absolute method to length.
Contributor
Author
We discussed this on Discord quickly with @laurmaedje and agreed that |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
.to-absolute(styles)method tolengthto allow retrieving a length as absolute (without theempart) when in the right context.This changes fixes packages like tablex (https://github.com/PgBiel/typst-tablex) that use the following code: