Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES6 modules, use module bundler #282

Closed
wants to merge 8 commits into from

Conversation

simon04
Copy link
Collaborator

@simon04 simon04 commented Feb 16, 2017

  • install packages from npm via
  • use ES6 module export/import
  • use webpack for bundling the application
  • make the tests run again

This is work in progress; so far items 1+2 are started but not yet finished. What do you think?

@tyrasd
Copy link
Owner

tyrasd commented Feb 16, 2017

😍

What do you think?

Definitively a +1 from me. Thanks for tackling this!

Maybe we can also add to the todo list:

  • get rid of duplication between index.html and index_packaged.html (same for map*.html)
  • switch to different publishing mechanism: use gh-pages branch to contain only bundled stuff (like this maybe)

@simon04
Copy link
Collaborator Author

simon04 commented Feb 16, 2017

You can give it a try: npm install && npm run start for a development server and npm run build for a minified distribution build (see README for details).

I think we can drop the _packaged.html files completely. It's now just a matter of running webpack in a different mode.

I still have to look into building map.html. Eventually, we can get rid of quite a few files in the repo.

@tyrasd
Copy link
Owner

tyrasd commented Feb 18, 2017

I think we can drop the _packaged.html files completely.

Yes. That's what I meant. ;-)

@tyrasd
Copy link
Owner

tyrasd commented Feb 18, 2017

I've pushed this PR onto a new branch in this repo now and added you as a collaborator, so we can work on this together! I'm opening a new PR for that branch in a minute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants