Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering pipeline #279

Merged
merged 13 commits into from Apr 5, 2018
Merged

Rendering pipeline #279

merged 13 commits into from Apr 5, 2018

Conversation

@tzachshabtay
Copy link
Owner

tzachshabtay commented Apr 5, 2018

Refactored the rendering loop to introduce the IRenderer, IRenderInstruction and IRenderPipeline interfaces.
This allows subscribing multiple renderers per entity, and reduces the number of dependencies on IObject.
Also, using the rendering instructions allowed for better synchronization between the update thread and rendering thread, eliminating jittering issues like those seen in Last & Furious.

The previous image renderer was removed, and its logic been replaced by 3 components: the existing image component will do the image rendering, the new border component will render the border and the new pivot renderer component will render the pivot point.
The label renderer was also removed and its logic moved to the text component.

This replaces the CustomRenderer property which has been removed.

Resolves #207

tzachshabtay added 13 commits Mar 30, 2018
Image component is no longer dependent on IImageRenderer and text
component is no longer dependent on ILabelRenderer (which was
completely removed).
# Conflicts:
#	Source/AGS.API/AGS.API.csproj
@tzachshabtay tzachshabtay merged commit b401cd2 into master Apr 5, 2018
5 of 6 checks passed
5 of 6 checks passed
coverage/coveralls Coverage decreased (-0.009%) to 33.255%
Details
CodeFactor 19 issues fixed. 5 issues found.
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tzachshabtay tzachshabtay deleted the Rendering branch Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.