Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lockfree pooling #10

Merged
merged 17 commits into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@improbable-til
Copy link
Contributor

improbable-til commented Mar 6, 2019

The PH-Tree currently uses synchronized object pools. This is inefficient in an environment with multiple PH-Trees running concurrently. This PR remedies this by creating one pool per PH-Tree.

improbable-til added some commits Feb 26, 2019

RD-93 lockfree pooling (#2)
* V13us without synchronized pools and NT

* ObjectPool<Node>

* V16 without synchronized pools

* V16 without synchronized pools

* V16 without synchronized pools

* V16 without synchronized pools

* V16 without synchronized pools

* V16 without synchronized pools
Merge branch 'master' into feature/RD-93-lockfree-pooling
# Conflicts:
#	src/main/java/ch/ethz/globis/phtree/util/unsynced/LongArrayArrayPool.java
#	src/main/java/ch/ethz/globis/phtree/util/unsynced/LongArrayPool.java
#	src/main/java/ch/ethz/globis/phtree/util/unsynced/ObjectArrayPool.java
#	src/main/java/ch/ethz/globis/phtree/util/unsynced/ObjectPool.java
#	src/main/java/ch/ethz/globis/phtree/v16/bst/BSTPool.java
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Mar 6, 2019

Codecov Report

Merging #10 into master will decrease coverage by 2.66%.
The diff coverage is 22.54%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #10      +/-   ##
============================================
- Coverage     29.37%   26.71%   -2.67%     
- Complexity     1477     1548      +71     
============================================
  Files           146      162      +16     
  Lines         16818    18299    +1481     
  Branches       2870     3128     +258     
============================================
- Hits           4940     4888      -52     
- Misses        11591    13149    +1558     
+ Partials        287      262      -25
Impacted Files Coverage Δ Complexity Δ
...va/ch/ethz/globis/phtree/v16/NodeIteratorNoGC.java 84.61% <ø> (ø) 15 <0> (ø) ⬇️
...lobis/phtree/v13SynchedPool/nt/NtIteratorMask.java 0% <ø> (ø) 0 <0> (?)
...thz/globis/phtree/v16hd/NodeIteratorListReuse.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ethz/globis/phtree/v16hd/NodeIteratorFullNoGC.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ch/ethz/globis/phtree/v13/PhQueryKnnMbbPPList.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/ch/ethz/globis/phtree/v16hd/Bits.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ch/ethz/globis/phtree/v13SynchedPool/NodePool.java 0% <ø> (ø) 0 <0> (?)
...h/ethz/globis/phtree/v16/NodeIteratorFullNoGC.java 76.92% <ø> (ø) 6 <0> (ø) ⬇️
.../main/java/ch/ethz/globis/phtree/PhTreeHelper.java 73.58% <ø> (ø) 11 <0> (ø) ⬇️
...n/java/ch/ethz/globis/phtree/v13/PhResultList.java 32.39% <ø> (ø) 3 <0> (ø) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981cb49...3336c49. Read the comment docs.

@tzaeschke tzaeschke merged commit 5ed3445 into tzaeschke:master Mar 8, 2019

1 of 3 checks passed

codecov/patch 22.54% of diff hit (target 29.37%)
Details
codecov/project 26.71% (-2.67%) compared to 981cb49
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.