Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you! #16

Closed
aldrinmartoq opened this Issue May 30, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@aldrinmartoq
Copy link

aldrinmartoq commented May 30, 2018

Hi @philr, just wanted to thank you for this package, couldn't find you on twitter.

I'm trying to resolve the problem when a new version of tzdata is released, so I made a couple of things:

  1. a ruby package that contains each version of the database in JSON files, and can return the diff (for ex: what do I have to check in my system if I'm in 2016c and install 2017a, for America/Santiago and America/Punta_Arenas). I extracted all the data from your tzinfo-data gem.
  2. a npm package that uses the json data generated above, and do the same in javascript.
  3. a demo to see the changes, for example: here you can see the changes above for America/Santiago → America/Punta_Arenas.

I will post a medium post later on the topic, but thanks again for your work.

@philr

This comment has been minimized.

Copy link
Member

philr commented Jun 2, 2018

Thanks for letting me know about your new project. It looks interesting. I've written scripts before to compare the offsets of used time zones between different tzinfo-data versions, but this is much more comprehensive.

I've had a quick look at your DataGenerator code. I note that it is currently accessing the protected #info method to obtain transition data. Is there a reason why you're not using the public TZInfo::Timezone#transitions_up_to method instead?

@aldrinmartoq

This comment has been minimized.

Copy link
Author

aldrinmartoq commented Jun 3, 2018

Oh no, you got me doing something inappropriate ;-)

Sorry, I use the protected methods because wanted the full list of transitions, and didn't want a hardcoded end date.

By the way, the moving 50 year limit is kind of an issue for me now, the utilities reports changes between versions when nothing changed from the tzdb perspective, like this one.

I'm still working on documentation, I think it looks good enough so far.

@philr philr closed this Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.