New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
America/Montreal is missing from zone.tab #2
Comments
If you want to manually add America/Montreal back in to the TZInfo::Data countries index, you can do so by modifying However, removing America/Montreal from zone.tab was an intentional change made in tzdata v2013e (and therefore also in TZInfo::Data v1.2013.5). Unless you require time zone definitions from before 1970, you should probably swap to America/Toronto instead. |
Now every Rails project will have to keep their own mappings of Montreal -> "America/Toronto" and/or "America/Montreal" -> "America/Toronto" and/or |
The America/Montreal zone still exists and can still be used. The only difference is that America/Montreal won't appear in the countries index (e.g. in the array returned by As far as I can see, Rails doesn't actually have a Montreal time zone, so won't be affected directly. The zone.tab file (and by extension the TZInfo countries index) changes frequently. Please see the comments in zone.tab for the reasoning behind which zones are included. If you are using the countries index to provide a UI for selecting a time zone, this interface should be coded to allow for added and removed zones. The whole point of TZInfo::Data is to repackage the standard IANA Timezone Database. I am therefore not going to make any changes in TZInfo::Data that haven't first published in the IANA Timezone Database. |
Understood. People can at least find this discussion to understand the issue with Montreal. Thanks. |
After scratching my head for quite a well, found this very, very useful thread. Timezones are a complete mess! The
commit hash for more reference: eggert/tz@2022cdd As mentioned above by @guyboertje , any application that provides utility functions to return list of zones of countries, will have to keep this explicit mapping of
But atleast for these zones, they have an entry in the |
I have just raised an issue on the tz repo
https://github.com/eggert/tz/issues/4
Seems like a revert was not completely done. Is there any way it can be added back into zone.tab and the ruby side too?
The text was updated successfully, but these errors were encountered: