Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from ThreadSafe::Cache to Concurrent::Map #46

Closed
philr opened this issue Feb 4, 2016 · 2 comments
Closed

Switch from ThreadSafe::Cache to Concurrent::Map #46

philr opened this issue Feb 4, 2016 · 2 comments

Comments

@philr
Copy link
Member

@philr philr commented Feb 4, 2016

See the discussion on #45.

The thread_safe gem has been merged into concurrent-ruby and thread_safe is being deprecated.

The code should be changed to use Concurrent::Map from concurrent-ruby instead of ThreadSafe::Cache (Concurrent::Map is a carbon copy of ThreadSafe::Cache).

tzinfo currently has a required_ruby_version of >= 1.8.7. This would need changing to >= 1.9.3 to match concurrent-ruby. Some of the code to support Ruby 1.8 in and around ruby_core_support.rb could also then be dropped.

@kares
Copy link

@kares kares commented Sep 11, 2018

Hello Phil, noticed thread_safe is still being pulled in (along side concurrent-ruby in Rails 5.x)
since there's work done to get rid off it on master, for some time, was wondering if you plan on releasing?
assuming you do not want it in a 1.2 minor release due backwards compatibility.

@philr
Copy link
Member Author

@philr philr commented Sep 13, 2018

@kares My intention is to make a 2.0.0 release from master sometime in the next few weeks.

This won't immediately help with Rails 5.x though - changes will be needed to work with tzinfo v2.

I could possibly look into creating a 1.3.0 release too that includes the concurrent-ruby change as well as the required increase to the required_ruby_version. This would be usable by Rails 5.x (activesupport depends on ~> 1.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.