Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #47 to a new minor version #65

Closed
kalleth opened this issue Feb 4, 2017 · 1 comment
Closed

Backport #47 to a new minor version #65

kalleth opened this issue Feb 4, 2017 · 1 comment

Comments

@kalleth
Copy link

@kalleth kalleth commented Feb 4, 2017

To support ruby 2.4.0 in rails 4.2 (see my backport rails/rails#27905) and completely remove the deprecation warnings for Fixnum caused by the unsupported thread_safe gem, it'd be great if you could release a 1.2.3 version containing just PR #47. That way I can upgrade that entirely and then no deprecation warnings happen on any old rails apps running 4.2 :)

Please let me know if I can help at all with this!

@philr
Copy link
Member

@philr philr commented Feb 9, 2017

There's a merged pull request (ruby-concurrency/thread_safe#29) to fix the Ruby 2.4 warnings in the thread_safe gem.

A new release of thread_safe that fixes the warnings sounds like a better solution than releasing a minor update to tzinfo that changes a dependency.

@philr philr closed this Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.