Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`TZInfo::Country` no information about linked timezones #71

Closed
davispuh opened this issue Sep 8, 2017 · 2 comments
Closed

`TZInfo::Country` no information about linked timezones #71

davispuh opened this issue Sep 8, 2017 · 2 comments

Comments

@davispuh
Copy link

@davispuh davispuh commented Sep 8, 2017

I want to get all timezones for specific country, but TZInfo::Country.zone_identifiers doesn't return linked timezones.

For example

TZInfo::Country.get('SS').zone_identifiers
=> ["Africa/Khartoum"]

TZInfo::Timezone.get('Africa/Juba').canonical_zone.identifier
=> "Africa/Khartoum"

Thus, I also want to get Africa/Juba for SS

Currently seems would need to go over all linked timezones and check their canonical zone against already returned zones.

@philr
Copy link
Member

@philr philr commented Sep 8, 2017

Please refer to my comment on #60 (which is essentially the same issue, but talking about Croatia rather than South Sudan).

The IANA Time Zone database defines Africa/Khartoum as the (only) time zone for SS. TZInfo is just returning the data from the Time Zone database unmodified.

@philr philr closed this Sep 8, 2017
@davispuh
Copy link
Author

@davispuh davispuh commented Sep 8, 2017

That is based on current status, but in past it was Africa/Juba, see zone.tab

I'm using TZInfo for processing historical data thus there it would appear as Africa/Juba instead of Africa/Khartoum

Anyway okay I'll just go over all_linked_zones as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants