Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow offsets and transitions to be retrieved from Timezone #1
Thank you for submitting this pull request.
I've actually been working on something similar and have just pushed my changes to master. The key difference between your and my changes is that I'm only supporting getting the transitions and offsets for a range of time.
The reason for requiring the range is that I'm planning to add support for including rules that define indefinitely repeating future transitions. This would mean that there would be an infinite number of transitions for many of the timezones (making returning all of them impossible!).
The main change (adding transitions_up_to and offsets_up_to to Timezone) is in 3f1364e. I've also made a few additional changes to clean up (and rename) the TimezoneTransitionInfo and TimezoneOffsetInfo classes now that they are available as part of the public interface.
@benhass I'm only doing data updates and bug fixes on the 0.3.x branch now, so I'm not going to backport this change.
If you want to, it looks like it would be reasonably straight-forward to monkey patch this change onto v0.3.38. I think all the dependencies will be there, so it should just be a case of adding the new methods. Note that the