Issue 39: return nil if nil is passed to utc_to_local #51

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@vivekbisen

vivekbisen commented May 25, 2016

@aug-riedinger would like to see nil returned as mentioned in #39. When nil is passed as an argument to utc_to_local method, -18000 is returned for some reason. That doesn't seem like nil to me. So, this should fix it.

@augnustin

This comment has been minimized.

Show comment
Hide comment

👍 😄

@philr

This comment has been minimized.

Show comment
Hide comment
@philr

philr Jan 3, 2017

Member

Thanks for submitting this pull request.

I've decided instead to have TZInfo raise an exception when a nil argument is passed to utc_to_local (and other Timezone methods).

Member

philr commented Jan 3, 2017

Thanks for submitting this pull request.

I've decided instead to have TZInfo raise an exception when a nil argument is passed to utc_to_local (and other Timezone methods).

@philr philr closed this Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment