Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 39: return nil if nil is passed to utc_to_local #51

Closed
wants to merge 1 commit into from
Closed

Issue 39: return nil if nil is passed to utc_to_local #51

wants to merge 1 commit into from

Conversation

vivekbisen
Copy link

@vivekbisen vivekbisen commented May 25, 2016

@aug-riedinger would like to see nil returned as mentioned in #39. When nil is passed as an argument to utc_to_local method, -18000 is returned for some reason. That doesn't seem like nil to me. So, this should fix it.

@augnustin
Copy link

augnustin commented May 26, 2016

👍 😄

@philr
Copy link
Member

philr commented Jan 3, 2017

Thanks for submitting this pull request.

I've decided instead to have TZInfo raise an exception when a nil argument is passed to utc_to_local (and other Timezone methods).

@philr philr closed this Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants