Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight memory reduction #57

Merged
merged 2 commits into from Oct 3, 2016
Merged

Conversation

@AaronLasseigne
Copy link
Contributor

AaronLasseigne commented Sep 21, 2016

closes #54

Doing a basic get showed a slight reduction in objects created.

Using:

require 'rubygems'
require 'memory_profiler'
require 'tzinfo'

MemoryProfiler.report(ignore_files: 'rubygems') {
  TZInfo::Timezone.get('America/New_York')
}.pretty_print

Before:

allocated memory by gem
-----------------------------------
   1294730  tzinfo
        40  concurrent-ruby-1.0.2
        40  other

After:

allocated memory by gem
-----------------------------------
   1225130  tzinfo
        40  concurrent-ruby-1.0.2
        40  other

5.38% lower memory usage

@philr philr merged commit ba72d8e into tzinfo:master Oct 3, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
philr added a commit that referenced this pull request Oct 3, 2016
@philr
Copy link
Member

philr commented Oct 3, 2016

Thank you for submitting this pull request. I've merged it into master.

@philr philr mentioned this pull request Oct 3, 2016
@AaronLasseigne AaronLasseigne deleted the AaronLasseigne:slight-memory-reduction branch Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.