Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TZInfo::Timezone#abbr #93

merged 1 commit into from Oct 7, 2018


Copy link

@nobu nobu commented Sep 25, 2018

I want to suggest TZInfo::Timezone#abbr which returns the abbreviation of the Timezone at the given time.

Currently, TZInfo::Timezone provides a way to get an abbreviated name as tz.strftime("%Z"), but it feels a roundabout route.

which returns the abbreviation of this Timezone at the given time.
@philr philr merged commit 8c52f82 into tzinfo:master Oct 7, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
philr added a commit that referenced this pull request Oct 7, 2018
Copy link

@philr philr commented Oct 7, 2018

Thanks. I've merged this change.

I renamed the method abbreviation (for consistency with the existing TimezoneOffset and TimezonePeriod methods). I've kept abbr as an alias though as I can see it is going to be used by the Time class.

@nobu nobu deleted the nobu:feature/Timezone#abbr branch Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants