Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define =~ method on Timezone identifier #99

Merged
merged 1 commit into from Apr 30, 2019

Conversation

@itsWill
Copy link
Contributor

commented Apr 26, 2019

It's useful to match agains a timezones identifier using regex.
e.g. this rails issue: rails/rails#35973 this
commit overrides the =~ operator to the Timezone class so that clients
can match against its identifier.

Define =~ method on Timezone identifier
It's useful to match against a timezones identifier using regex.
e.g. this rails issue: rails/rails#35973 this
commit introduces the =~ operator to the Timezone class so that clients
can match against its identifier by suppliying a regex.

@itsWill itsWill force-pushed the itsWill:define_match_operator_on_timezone branch from 81bf61f to be116b2 Apr 26, 2019

@itsWill

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

🤔 I can't get a lot of insight out of the build failure, it seems like it's struggling to resolve the concurrent-ruby version, this seems pretty unrelated to the changes here.

@philr philr merged commit be116b2 into tzinfo:master Apr 30, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

philr added a commit that referenced this pull request Apr 30, 2019

@philr

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Thank you for submitting this pull request. I've merged the change.

The build failure was unrelated. It was caused by an error verifying the rubygems.org TLS certificate. I've committed 719204b as a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.