From e3e3f2b892e73f4daa25f55d10b19572e945cffc Mon Sep 17 00:00:00 2001 From: "Dr. Sebastian Lehrig" Date: Tue, 13 Jun 2023 20:18:03 +0200 Subject: [PATCH] Fix 5007 by adding build ver. to multi-arch build (#7094) --- components/centraldashboard/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/components/centraldashboard/Makefile b/components/centraldashboard/Makefile index a7debe832a3..2f86f908f96 100644 --- a/components/centraldashboard/Makefile +++ b/components/centraldashboard/Makefile @@ -24,7 +24,7 @@ docker-build: docker build ${DOCKER_BUILD_OPTS} -t $(IMG):$(TAG) . \ --build-arg kubeflowversion=$(shell git describe --abbrev=0 --tags) \ --build-arg commit=$(COMMIT) \ - --label=git-verions=$(TAG) + --label=git-version=$(TAG) @echo Built $(IMG):$(TAG) docker-push: @@ -32,12 +32,12 @@ docker-push: .PHONY: docker-build-multi-arch docker-build-multi-arch: ## Build multi-arch docker images with docker buildx - docker buildx build --load --platform ${ARCH} --tag ${IMG}:${TAG} -f ${DOCKERFILE} . + docker buildx build --load --platform ${ARCH} --tag ${IMG}:${TAG} -f ${DOCKERFILE} . --build-arg kubeflowversion=$(shell git describe --abbrev=0 --tags) --build-arg commit=$(COMMIT) --label=git-version=$(TAG) .PHONY: docker-build-push-multi-arch docker-build-push-multi-arch: ## Build multi-arch docker images with docker buildx and push to docker registry - docker buildx build --platform ${ARCH} --tag ${IMG}:${TAG} --push -f ${DOCKERFILE} . + docker buildx build --platform ${ARCH} --tag ${IMG}:${TAG} --push -f ${DOCKERFILE} . --build-arg kubeflowversion=$(shell git describe --abbrev=0 --tags) --build-arg commit=$(COMMIT) --label=git-version=$(TAG) # Build but don't attach the latest tag. This allows manual testing/inspection of the image # first.