Skip to content


Browse files Browse the repository at this point in the history
pci: pcie-brcmstb: Fix inbound window configurations
So far we've assumed a fixed configuration for inbound windows as we had
a single user for this controller. But the controller's DMA constraints
were improved starting with BCM2711's B1 revision of the SoC, notably
available in CM4 and Pi400. They allow for wider inbound windows. We can
now cover the whole address space, whereas before we where limited to
the lower 3GB.

This information is passed to us through DT's 'dma-ranges' property and
it's specially important for us to honor it since some interactions with
the board's co-processor assume we're doing so (specifically the XHCI
firmware load operation, which is handled by the co-processor after
u-boot has correctly configured the PCIe controller).

Signed-off-by: Nicolas Saenz Julienne <>
Tested-by: Peter Robinson <>
Signed-off-by: Matthias Brugger <>
  • Loading branch information
Nicolas Saenz Julienne authored and mbgg committed Feb 18, 2021
1 parent 561bce3 commit c709243
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions drivers/pci/pcie_brcmstb.c
Expand Up @@ -432,6 +432,7 @@ static int brcm_pcie_probe(struct udevice *dev)
struct pci_controller *hose = dev_get_uclass_priv(ctlr);
struct brcm_pcie *pcie = dev_get_priv(dev);
void __iomem *base = pcie->base;
struct pci_region region;
bool ssc_good = false;
int num_out_wins = 0;
u64 rc_bar2_offset, rc_bar2_size;
Expand Down Expand Up @@ -468,13 +469,10 @@ static int brcm_pcie_probe(struct udevice *dev)
* TODO: When support for other SoCs than BCM2711 is added we may
* need to use the base address and size(s) provided in the dma-ranges
* property.
rc_bar2_offset = 0;
rc_bar2_size = 0xc0000000;

pci_get_dma_regions(dev, &region, 0);
rc_bar2_offset = region.bus_start - region.phys_start;
rc_bar2_size = 1ULL << fls64(region.size - 1);

tmp = lower_32_bits(rc_bar2_offset);
u32p_replace_bits(&tmp, brcm_pcie_encode_ibar_size(rc_bar2_size),
Expand Down

0 comments on commit c709243

Please sign in to comment.