Learning uboot transplantation start here #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbertux
pushed a commit
to OSSystems/u-boot
that referenced
this pull request
Sep 29, 2020
Compiling U-Boot with ubsan/asan libraries and running it in sandbox
may lead to below backtrace:
=> avb init 0
=> avb verify
## Android Verified Boot 2.0 version 1.1.0
read_is_device_unlocked not supported yet
common/avb_verify.c:407:31: runtime error: division by zero
AddressSanitizer:DEADLYSIGNAL
Reviewed-by: Igor Opaniuk <igor.opaniuk@linaro.org>
=================================================================
==9388==ERROR: AddressSanitizer: FPE on unknown address 0x0000004b467f \
(pc 0x0000004b467f bp 0x000000000000 sp 0x7ffd899fe150 T0)
#0 0x4b467e in mmc_byte_io common/avb_verify.c:407
#1 0x4b4c47 in mmc_byte_io common/avb_verify.c:532
#2 0x4b4c47 in read_from_partition common/avb_verify.c:533
#3 0x69dc0d in load_and_verify_vbmeta lib/libavb/avb_slot_verify.c:560
#4 0x6a1ee6 in avb_slot_verify lib/libavb/avb_slot_verify.c:1139
#5 0x45dabd in do_avb_verify_part cmd/avb.c:245
#6 0x4af77c in cmd_call common/command.c:499
u-boot#7 0x4af77c in cmd_process common/command.c:538
u-boot#8 0x46bafc in run_pipe_real common/cli_hush.c:1677
u-boot#9 0x46bafc in run_list_real common/cli_hush.c:1875
u-boot#10 0x46c780 in run_list common/cli_hush.c:2024
u-boot#11 0x46c780 in parse_stream_outer common/cli_hush.c:3216
u-boot#12 0x46d34b in parse_file_outer common/cli_hush.c:3299
u-boot#13 0x4ad609 in cli_loop common/cli.c:217
u-boot#14 0x4625ae in main_loop common/main.c:65
u-boot#15 0x46f2d1 in run_main_loop common/board_r.c:648
u-boot#16 0x640253 in initcall_run_list lib/initcall.c:30
u-boot#17 0x46f9d0 in board_init_r common/board_r.c:879
u-boot#18 0x40539b in main arch/sandbox/cpu/start.c:321
u-boot#19 0x7fa94925f82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
u-boot#20 0x408908 in _start (/srv/R/u-boot-master/u-boot+0x408908)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE common/avb_verify.c:407 in mmc_byte_io
==9388==ABORTING
Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com>
nekromant
pushed a commit
to RC-MODULE/u-boot
that referenced
this pull request
Feb 3, 2021
…-files-modifying to rcm-tx018-develop * commit '1bf0452882cbd787a17721da727cd421685618e1': 1. made dtsi file for each extention board 2. variable parameters nand and nor controllers move in new dtsi files
lbmeng
added a commit
to lbmeng/u-boot
that referenced
this pull request
Feb 18, 2021
Add a reST document to describe how to build and run U-Boot for the QEMU ppce500 machine. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org> Series-version: 2 Series-changes: 2 - add descriptions for VirtIO BLK, RTC and power off Series-to: Simon, Alexander Graf <agraf@csgraf.de>, Priyanka Jain <priyanka.jain@nxp.com> Series-cc: Tom, U-Boot Cover-letter: ppc: qemu: Convert qemu-ppce500 to driver model and enable additional driver support At present when building qemu-ppce500 the following warnings are seen: ===================== WARNING ====================== This board does not use CONFIG_DM. CONFIG_DM will be compulsory starting with the v2020.01 release. Failure to update may result in board removal. UPD include/generated/timestamp_autogenerated.h See doc/driver-model/migration.rst for more info. ==================================================== ===================== WARNING ====================== This board does not use CONFIG_DM_PCI Please update the board to use CONFIG_DM_PCI before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ==================================================== ===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ==================================================== The conversion of qemu-ppce500 board to driver model is long overdue. When testing the exisitng qemu-ppce500 support, PCI was found broken. This is caused by 2 separate issues: - One issue was caused by U-Boot: Commit e002474 ("pci: pci-uclass: Dynamically allocate the PCI regions") Patch u-boot#1 updated the non-DM fsl_pci_init driver to dynamically allocate the PCI regions, to keep in sync with the pci uclass driver - One issue was caused by QEMU: commit e6b4e5f4795b ("PPC: e500: Move CCSR and MMIO space to upper end of address space") commit cb3778a0455a ("PPC: e500 pci host: Add support for ATMUs") Patch u-boot#3-4 fixed this issue to keep in sync with latest QEMU upstream Patch u-boot#5-8, u-boot#34-36 are minor fixes and clean-ups. Starting from patch#9, these are driver model conversion patches. Patch u-boot#11-17 are mainly related to CONFIG_ADDR_MAP, a library to support targets that have non-identity virtual-physical address mappings. A new command 'addrmap' is introduced to aid debugging, and a fix to arch/powerpc/asm/include/io.h is made to correct the usage of CONFIG_ADDR_MAP as it can only be used in the post- relocation phase. Also the initialization of this library is moved a bit earlier in the post-relocation phase otherwise device drivers won't work. Patch u-boot#19-21 are 85xx PCI driver fixes. It adds support to controller register physical address beyond 32-bit, as well as support to 64-bit bus and cpu address as current upstream QEMU uses 64-bit cpu address. Starting from patch#24, these are additional driver support patches. Patch u-boot#24, u-boot#26 are minor fix to the 'virtio' command and BLK driver dependency. Patch u-boot#25 enables the VirtIO NET support as by default a VirtIO standard PCI networking device is connected as an ethernet interface at PCI address 0.1.0. Patch u-boot#27 enables the VirtIO BLK driver support. Patch u-boot#28-30 enables the GPIO support. Patch u-boot#31-32 enables poweroff via GPIO. Patch u-boot#33 enables RTC over the I2C bus. Patch u-boot#37 moves the qemu-ppce500 boards codes to board/emulation as that is the place for other QEMU targets like x86, arm, riscv. Patch u-boot#38 adds a reST document to describe how to build and run U-Boot for the QEMU ppce500 machine. I hope we can make this series to U-Boot v2021.04 release. This series is available at u-boot-x86/qemu-ppc for testing. This cover letter is cc'ed to QEMU mailing list for a heads-up. A future patch will be sent to QEMU mailing list to bring its in-tree U-Boot source codes up-to-date. END
lbmeng
added a commit
to lbmeng/u-boot
that referenced
this pull request
Feb 25, 2021
Add a reST document to describe how to build and run U-Boot for the QEMU ppce500 machine. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Priyanka Jain <priyanka.jain@nxp.com> Series-version: 3 Series-changes: 3 - rebase on top of u-boot/master Series-changes: 2 - add descriptions for VirtIO BLK, RTC and power off Series-to: Simon, Alexander Graf <agraf@csgraf.de>, Priyanka Jain <priyanka.jain@nxp.com> Series-cc: Tom, U-Boot Cover-letter: ppc: qemu: Convert qemu-ppce500 to driver model and enable additional driver support At present when building qemu-ppce500 the following warnings are seen: ===================== WARNING ====================== This board does not use CONFIG_DM. CONFIG_DM will be compulsory starting with the v2020.01 release. Failure to update may result in board removal. UPD include/generated/timestamp_autogenerated.h See doc/driver-model/migration.rst for more info. ==================================================== ===================== WARNING ====================== This board does not use CONFIG_DM_PCI Please update the board to use CONFIG_DM_PCI before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ==================================================== ===================== WARNING ====================== This board does not use CONFIG_DM_ETH (Driver Model for Ethernet drivers). Please update the board to use CONFIG_DM_ETH before the v2020.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/migration.rst for more info. ==================================================== The conversion of qemu-ppce500 board to driver model is long overdue. When testing the exisitng qemu-ppce500 support, PCI was found broken. This is caused by 2 separate issues: - One issue was caused by U-Boot: Commit e002474 ("pci: pci-uclass: Dynamically allocate the PCI regions") Patch u-boot#1 updated the non-DM fsl_pci_init driver to dynamically allocate the PCI regions, to keep in sync with the pci uclass driver - One issue was caused by QEMU: commit e6b4e5f4795b ("PPC: e500: Move CCSR and MMIO space to upper end of address space") commit cb3778a0455a ("PPC: e500 pci host: Add support for ATMUs") Patch u-boot#3-4 fixed this issue to keep in sync with latest QEMU upstream Patch u-boot#5-8, u-boot#34-36 are minor fixes and clean-ups. Starting from patch#9, these are driver model conversion patches. Patch u-boot#11-17 are mainly related to CONFIG_ADDR_MAP, a library to support targets that have non-identity virtual-physical address mappings. A new command 'addrmap' is introduced to aid debugging, and a fix to arch/powerpc/asm/include/io.h is made to correct the usage of CONFIG_ADDR_MAP as it can only be used in the post- relocation phase. Also the initialization of this library is moved a bit earlier in the post-relocation phase otherwise device drivers won't work. Patch u-boot#19-21 are 85xx PCI driver fixes. It adds support to controller register physical address beyond 32-bit, as well as support to 64-bit bus and cpu address as current upstream QEMU uses 64-bit cpu address. Starting from patch#24, these are additional driver support patches. Patch u-boot#24, u-boot#26 are minor fix to the 'virtio' command and BLK driver dependency. Patch u-boot#25 enables the VirtIO NET support as by default a VirtIO standard PCI networking device is connected as an ethernet interface at PCI address 0.1.0. Patch u-boot#27 enables the VirtIO BLK driver support. Patch u-boot#28-30 enables the GPIO support. Patch u-boot#31-32 enables poweroff via GPIO. Patch u-boot#33 enables RTC over the I2C bus. Patch u-boot#37 moves the qemu-ppce500 boards codes to board/emulation as that is the place for other QEMU targets like x86, arm, riscv. Patch u-boot#38 adds a reST document to describe how to build and run U-Boot for the QEMU ppce500 machine. I hope we can make this series to U-Boot v2021.04 release. This series is available at u-boot-x86/qemu-ppc for testing. This cover letter is cc'ed to QEMU mailing list for a heads-up. A future patch will be sent to QEMU mailing list to bring its in-tree U-Boot source codes up-to-date. END
paralin
pushed a commit
to skiffos/u-boot
that referenced
this pull request
Jun 12, 2022
Fix checkpatch warning about u-boot/include/configs/starfive-vic7100.h:
```
ERROR: fdt or initrd relocation disabled at boot time
+ "fdt_high=0xffffffffffffffff\0" \
ERROR: fdt or initrd relocation disabled at boot time
+ "initrd_high=0xffffffffffffffff\0" \
```
Further discussion of why this is not needed and the problem its presence was causing in issue u-boot#19
paralin
pushed a commit
to skiffos/u-boot
that referenced
this pull request
Jun 29, 2022
Fix checkpatch warning about u-boot/include/configs/starfive-vic7100.h:
```
ERROR: fdt or initrd relocation disabled at boot time
+ "fdt_high=0xffffffffffffffff\0" \
ERROR: fdt or initrd relocation disabled at boot time
+ "initrd_high=0xffffffffffffffff\0" \
```
Further discussion of why this is not needed and the problem its presence was causing in issue u-boot#19
vfalanis
pushed a commit
to polarfire-soc/u-boot
that referenced
this pull request
May 18, 2023
…ces to "PolarFire SoC Video Kit" Merge in FPGA_PFSOC_ES/u-boot from FPGA_PFSOC_SEV_SOLUTIONS/u-boot:mpfs-video-kit-rename to mpfs-uboot-2022.01-next * commit 'a93de144cd6445426cbc79b050b4fc9b37d5ffe9': board: microchip: sev-kit: Rename all references to "PolarFire SoC Video Kit"
charkear
pushed a commit
to HewlettPackard/gxp-uboot
that referenced
this pull request
Jun 28, 2023
Update gxp_board.c to include the Open BMC subsystem ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not submit a Pull Request via github. Our project makes use of
mailing lists for patch submission and review. For more details please
see https://www.denx.de/wiki/U-Boot/Patches