Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id remove testutils, add more tests #2641

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

binjip978
Copy link
Contributor

No description provided.

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.15 🎉

Comparison is base (809e479) 74.93% compared to head (80bb85d) 75.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2641      +/-   ##
==========================================
+ Coverage   74.93%   75.08%   +0.15%     
==========================================
  Files         413      413              
  Lines       41661    41662       +1     
==========================================
+ Hits        31217    31283      +66     
+ Misses      10444    10379      -65     
Impacted Files Coverage Δ
cmds/core/id/id.go 73.91% <92.30%> (+57.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Mar 23, 2023
@binjip978 binjip978 changed the title Id testutils id remote testutils, add more tests Mar 23, 2023
@binjip978 binjip978 changed the title id remote testutils, add more tests id remove testutils, add more tests Mar 23, 2023
Copy link
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. One question: is it worth using t.Run for any of these tests.

golangci-lint always yells at me when I don't :-)

@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Mar 23, 2023
@binjip978
Copy link
Contributor Author

From this document https://github.com/golang/go/wiki/TestComments#go-test-comments I don't see why we need to add t.Run to table driven tests. But I'm overusing t.Fatal in table driven tests. Will probably address it in separate PR to cover multiple commands.

@binjip978 binjip978 merged commit 107f179 into u-root:main Mar 23, 2023
@binjip978 binjip978 deleted the id-testutils branch March 23, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting author Waiting for new changes or feedback for author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants