Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmds/core/grep: fix -l flag not showing filenames #2680

Merged
merged 2 commits into from
May 22, 2023

Conversation

binjip978
Copy link
Contributor

No description provided.

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5b74f07) 75.32% compared to head (3d1358e) 75.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2680   +/-   ##
=======================================
  Coverage   75.32%   75.32%           
=======================================
  Files         413      413           
  Lines       41964    41964           
=======================================
  Hits        31609    31609           
  Misses      10355    10355           
Impacted Files Coverage Δ
cmds/core/grep/grep.go 81.45% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label May 20, 2023
@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. automerge Applying this label auto-merges the PR when ready and removed Awaiting reviewer Waiting for a reviewer. labels May 22, 2023
@binjip978 binjip978 merged commit 41a8c30 into u-root:main May 22, 2023
@binjip978 binjip978 deleted the grep-l-bug branch May 22, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Applying this label auto-merges the PR when ready Awaiting author Waiting for new changes or feedback for author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants