/pkg/hsskey: Include backup HSS #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
rminnich
reviewed
Sep 28, 2023
rminnich
added
the
Awaiting author
|
I agree that it'd be nice to have this covered by a test, but due to the way this function uses the IPMI interface, it would require adding some awkward dependency injection code, which would end up being more complicated and invasive than the actual logic change itself here. |
Fusxfaranto
added
Awaiting reviewer
rminnich
approved these changes
Oct 20, 2023
rminnich
added
Awaiting author
Refactor getHssFromIpmi to use an ordered list of HSS string prefixes, allowing the use of "backup" HSS keys (which will only be used after all "regular" HSS keys have been tried). Signed-off-by: Albert Morgese <amorgese@google.com>
Fusxfaranto
force-pushed
the
hss-backup
branch
from
fb58751
to
146165e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor getHssFromIpmi to use an ordered list of HSS string prefixes, allowing the use of "backup" HSS keys (which will only be used after all "regular" HSS keys have been tried).