dhcpv6: correct PreferredLifetime and ValidLifetime got from dhcpv6 l… #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ease The unit of PreferedLft and ValidLft is second. But the type of PreferredLifetime and ValidLifetime in dhcpv6 lease is time.Duration and its default unit is nanosecond. Signed-off-by: Yiwei Tang <tangyiwei.2022@bytedance.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
=======================================
Coverage 75.14% 75.14%
=======================================
Files 433 433
Lines 43034 43034
=======================================
Hits 32339 32339
Misses 10695 10695 ☔ View full report in Codecov by Sentry. |
|
Wow. That's a nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ease
The unit of PreferedLft and ValidLft is second. But the type of PreferredLifetime and ValidLifetime in dhcpv6 lease is time.Duration and its default unit is nanosecond.