Spidev #2838
Merged
Spidev #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the error messages as they were, you had to find and read source to figure out legal usages. flag.Usage() does not show valid usage; you have to call fs.FlagUsages() to get that. We can use the errors.Is in tests, which is nicer. Use os errors for mock tests, to make errors.Is easier. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
pflag takes it upon itself to spew errors to stdout. It is hard to get consistent error invocation output from it, but this is at least better than it was. The output now looks like this (sidecore is running them on a visionfive2 board): ronsexcllentmbp:spidev rminnich$ sidecore vf2 ./spidev 1970/01/01 02:47:24 usage: -D, --device string spidev device (default "/dev/spidev0.0") -s, --speed uint32 max speed in Hz (default 500000) <raw|sfdp> (this formatting still sucks). ronsexcllentmbp:spidev rminnich$ sidecore vf2 ./spidev -t 1970/01/01 02:47:27 unknown flag:unknown shorthand flag: 't' in -t ronsexcllentmbp:spidev rminnich$ sidecore vf2 ./spidev -h Usage of spidev: -D, --device string spidev device (default "/dev/spidev0.0") -s, --speed uint32 max speed in Hz (default 500000) 1970/01/01 02:47:30 usage:<raw|sfdp> Note this is different than above, because pflag takes it upon itself to just print things out. We can get more control, at the cost or more code, but that is for another day. Most importantly, you at least get some idea what commands there are. Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
=======================================
Coverage 75.74% 75.74%
=======================================
Files 423 423
Lines 42720 42721 +1
=======================================
+ Hits 32358 32359 +1
Misses 10362 10362
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
binjip978
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make spidev a little more informative about what commands are available. Until this change, you had to try to find source to see what to do.