Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test timeout to 15m #2844

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Increase test timeout to 15m #2844

merged 1 commit into from
Jan 11, 2024

Conversation

hugelgupf
Copy link
Member

No description provided.

Signed-off-by: Chris Koch <chrisko@google.com>
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3826939) 75.76% compared to head (5ed0979) 75.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
- Coverage   75.76%   75.75%   -0.02%     
==========================================
  Files         423      423              
  Lines       42744    42744              
==========================================
- Hits        32386    32381       -5     
- Misses      10358    10363       +5     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.71% <ø> (ø)
integration/generic-tests/...-amd64 0.00% <ø> (ø)
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 0.00% <ø> (ø)
integration/gotests/...-amd64 74.02% <ø> (ø)
integration/gotests/...-arm64 74.96% <ø> (ø)
pkg/...-amd64 76.16% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf hugelgupf marked this pull request as ready for review January 11, 2024 03:07
@hugelgupf hugelgupf requested review from rminnich, 10000TB, MDr164 and a team January 11, 2024 03:07
@rminnich
Copy link
Member

testing it now to see if it floats my boat.

@rminnich
Copy link
Member

it does not help my problem but seems worth doing. I have no understanding of what's going wrong atm.

@rminnich rminnich merged commit df70864 into u-root:main Jan 11, 2024
25 checks passed
@hugelgupf hugelgupf deleted the timeout branch January 12, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants