pkg/acpi: lift loop condition and remove Sprintf

[binjip978]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00ccdc3) 75.69% compared to head (2327331) 75.69%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2851   +/-   ##
=======================================
  Coverage   75.69%   75.69%           
=======================================
  Files         425      425           
  Lines       42855    42853    -2     
=======================================
- Hits        32438    32437    -1     
+ Misses      10417    10416    -1     

Flag	Coverage Δ
.-amd64	67.87% <ø> (ø)
cmds/...-amd64	71.73% <ø> (+0.05%)	⬆️
integration/generic-tests/...-amd64	0.00% <ø> (ø)
integration/generic-tests/...-arm	0.00% <ø> (ø)
integration/generic-tests/...-arm64	0.00% <ø> (ø)
integration/gotests/...-amd64	73.95% <100.00%> (-0.01%)	⬇️
integration/gotests/...-arm64	74.89% <0.00%> (+<0.01%)	⬆️
pkg/...-amd64	76.09% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rminnich]

see my question, I've started doing silly things like this go make sure it will work, but there has to be a better way to do this
var b [4]byte
var data []byte
bytes.NewBuffer(data).Read(b[:])
fmt.Printf("%q\n", string(b[:]))
kinda gross, but safe. is there not some package that does this? I've looked in some of the generic packages but not found it yet. But .. it ought to exist.

still, we've had this package for years, but still ...

[binjip978]

var b [4]byte
var data []byte
bytes.NewBuffer(data).Read(b[:])
fmt.Printf("%q\n", string(b[:]))

What the difference with this snippet:

data := make([]byte, 4)
fmt.Printf("%q\n", string(data[:]))

We will got "\x00\x00\x00\x00" in both cases?

[rminnich]

The only difference: try it with
var b [0]byte
var data []byte
bytes.NewBuffer(data).Read(b[:])
fmt.Printf("%q\n", string(b[:]))

[rminnich]

it's a google tradition in a PR to ask you to fix stuff somebody else wrote wrong :-)