This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Fix integration testing, add to CI #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
paulzzy
commented
Aug 26, 2022
paulzzy
commented
- Run tests with standalone integration.sh
- Integration testing workflow now in ci.yml instead of nightly.yml
- Run tests with standalone integration.sh - Integration testing workflow now in ci.yml instead of nightly.yml Signed-off-by: Paul Zhang <paulz@ucla.edu>
paulzzy
force-pushed
the
move-integration-to-ci
branch
from
09e2b16
to
2949e7e
Compare
Running `./webboot` with 0.9.0 `u-root` fails to build initramfs Signed-off-by: Paul Zhang <paulz@ucla.edu>
ryukinix
previously approved these changes
Sep 7, 2022
paulzzy
force-pushed
the
move-integration-to-ci
branch
2 times, most recently
from
adae404
to
f267183
Compare
paulzzy
changed the title
paulzzy
force-pushed
the
move-integration-to-ci
branch
from
f267183
to
4e96d33
Compare
- Remove CentOS 8 because it's not maintained (see https://www.centos.org/centos-linux-eol/) - Add webboot binary, integration testing artifacts, and macOS .DS_Store to gitignore Signed-off-by: Paul Zhang <paulz@ucla.edu>
Distros regularly update to new versions, but webboot's distro metadata is hardcoded. Although integration testing is triggered on push and pull requests, webboot development is not always active. Testing distro metadata regularly helps catch out-of-date info sooner. Signed-off-by: Paul Zhang <paulz@ucla.edu>
paulzzy
force-pushed
the
move-integration-to-ci
branch
from
4e96d33
to
98742b6
Compare
|
I updated all distro links, so downloading ISOs shouldn't be a problem. However, most distros (except TinyCore) have outdated boot info that causes the tests to fail. I'll leave that as a TODO, since the integration testing logic is now fixed and only config info is wrong. |
- Fix Fedora ISO download link - TODO: Fix other distros Signed-off-by: Paul Zhang <paulz@ucla.edu>
paulzzy
force-pushed
the
move-integration-to-ci
branch
from
1b299cc
to
1875322
Compare
|
what should we do about the failures? merge anyway? |
|
oh I read your comment. Suggestion: add a map called broken, and add these to it, and VERY LOUDLY log that they are being skipped? If you're out of time, I'll do that. |
|
That's a good suggestion! I am out of time, so I would greatly appreciate if you could implement it. |
rminnich
approved these changes
Sep 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.