Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip empty lines #259

Open
wants to merge 1 commit into
base: master
from
Open

Skip empty lines #259

wants to merge 1 commit into from

Conversation

@todeveni
Copy link

todeveni commented Feb 10, 2020

Google Calendar public ICS calendars have an empty line at the end of the file and ics-parser tries to parse it into an key:value array.

  1   Illuminate\Foundation\Bootstrap\HandleExceptions::handleError("Trying to access array offset on value of type bool", "/vendor/johngrogg/ics-parser/src/ICal/ICal.php")
      /vendor/johngrogg/ics-parser/src/ICal/ICal.php:627
@u01jmg3 u01jmg3 self-assigned this Feb 10, 2020
@u01jmg3 u01jmg3 self-requested a review Feb 10, 2020
@u01jmg3 u01jmg3 assigned todeveni and unassigned u01jmg3 Feb 10, 2020
@u01jmg3

This comment has been minimized.

Copy link
Owner

u01jmg3 commented Feb 10, 2020

Thanks for reporting

Would the check be better placed before the cleanData() call?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.