Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golem.de anti adblocker #184

Closed
alexara opened this issue Nov 8, 2016 · 8 comments
Closed

golem.de anti adblocker #184

alexara opened this issue Nov 8, 2016 · 8 comments

Comments

@alexara
Copy link

@alexara alexara commented Nov 8, 2016

URL where the issue occurs

http://www.golem.de/news/sicherheitsluecke-alle-android-geraete-koennen-durch-dirty-cow-gerootet-werden-1611-124326.html

Describe the issue

There's an anti ad-blocker bait on the website: The big banner you can see in the screenshot.
When the banner gets blocked by www.golem.de###screen > div:nth-of-type(1) the adblocker is detected and the page content blurs.

It would be convenient to hide this banner somehow without triggering the anti adblock measurements.

Screenshot(s)

bildschirmfoto_2016-11-08_12-51-06

Versions

  • Browser/version: FF49
  • uBlock Origin version: 1.9.16

Settings

Default + EasyList Germany + all anti adblocker filter list
Own rule: www.golem.de###screen > div:nth-of-type(1)

@gorhill

This comment has been minimized.

Copy link
Member

@gorhill gorhill commented Nov 8, 2016

It's self-promotion, not an ad.

In any case, a plain filter is good enough here, so report to EasyList Germany.

@gorhill gorhill closed this Nov 8, 2016
@jjohns71

This comment has been minimized.

Copy link

@jjohns71 jjohns71 commented Nov 8, 2016

@alexara You can block just the cosmetic element with the following filter (leaves an empty white box in place) without the page content blurring by using an xpath filter, this seems to work for me:

golem.de##:xpath(.//*[@class="golem-accountpromo squeeze"])

@gorhill gorhill reopened this Nov 8, 2016
@gorhill

This comment has been minimized.

Copy link
Member

@gorhill gorhill commented Nov 8, 2016

It would be convenient to hide this banner somehow without triggering the anti adblock measurements.

Sorry, I missed that part.

@gorhill

This comment has been minimized.

Copy link
Member

@gorhill gorhill commented Nov 8, 2016

How about:

golem.de###screen > div:has(:scope > [data-google-query-id])
golem.de##article:style(filter: none !important; pointer-events: initial !important; position: relative !important;)
golem.de##article ~ .formatted

But since it's self-promotion which does not prevent access to content, I should not add this to uBO's filters.

@gorhill

This comment has been minimized.

Copy link
Member

@gorhill gorhill commented Nov 8, 2016

This is an excellent case to motivate me to go ahead with a more generic solution in uBO I have thought more and more about lately.

@gorhill

This comment has been minimized.

Copy link
Member

@gorhill gorhill commented Nov 8, 2016

Custom filter for this case: golem.de##script:inject(abort-on-property-write.js, _sp_) (need 1.9.17b7).

@alexara

This comment has been minimized.

Copy link
Author

@alexara alexara commented Nov 10, 2016

Thank you very much @gorhill, you don't know how much I and surely many others are grateful for your (free!) work.

@fhamborg

This comment has been minimized.

Copy link

@fhamborg fhamborg commented Nov 22, 2016

thanks a lot :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.