New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFW! [Popup] javher.com #3031

Closed
jspenguin2017 opened this Issue Jul 26, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@jspenguin2017

jspenguin2017 commented Jul 26, 2018

URL(s) where the issue occurs

https://javher.com/video/watch-cesd00611-1532188800000

Describe the issue

Popups, and the video player has ads overlay.

Screenshot(s)

Let me know if you need screenshots.

Versions

  • Browser/version: Chrome 70
  • uBlock Origin version: 1.16.14

Settings

English default.

@okiehsch

This comment has been minimized.

Show comment
Hide comment
@okiehsch

okiehsch Jul 26, 2018

Contributor
avgle.com##script:inject(abort-on-property-read.js, ExoLoader.serve)
avgle.com##script:inject(nowebrtc.js)
avgle.com##script:inject(set-constant.js, showBlockIf, noopFunc)
||sub.avgle.com/fd/*$script,first-party

is the best I can come up with without breaking the video player.

Contributor

okiehsch commented Jul 26, 2018

avgle.com##script:inject(abort-on-property-read.js, ExoLoader.serve)
avgle.com##script:inject(nowebrtc.js)
avgle.com##script:inject(set-constant.js, showBlockIf, noopFunc)
||sub.avgle.com/fd/*$script,first-party

is the best I can come up with without breaking the video player.

@okiehsch okiehsch closed this in af7b8ee Jul 26, 2018

@bobsage123

This comment has been minimized.

Show comment
Hide comment
@bobsage123

bobsage123 Jul 27, 2018

Hmm, tested this on chrome and firefox and clicking the play button nothing happens.

bobsage123 commented Jul 27, 2018

Hmm, tested this on chrome and firefox and clicking the play button nothing happens.

@ZaphodBeebblebrox

This comment has been minimized.

Show comment
Hide comment
@ZaphodBeebblebrox

ZaphodBeebblebrox Jul 27, 2018

Member

You need to click on the tiny blue and white x first.

Member

ZaphodBeebblebrox commented Jul 27, 2018

You need to click on the tiny blue and white x first.

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Jul 27, 2018

This is the offending function, unfortunately I see no way around it without patching the code.

  var closeAd = function (e) {
    try {
      if (!e.screenX || e.originalEvent.isTrusted === false) {
        return;
      }
    } catch (e) {
    }
    if (isEmbedded && !window.open('javascript:close()', '_blank')) {
      window.location = redirectURL + '?from_embed';
      return;
    }
    $('#player_3x2_container').hide();
    $('#aoverlay').hide();
    localStorage[key] = 1;
    /*
    if (!played) {
      player.play();
      $('#close-btn-icon').removeClass('glyphicon-play');
      $('#close-btn-icon').addClass('glyphicon-remove');
      $('#close-btn-text').text(' 閉じる・Close');
      played = true;
    }*/
  };

jspenguin2017 commented Jul 27, 2018

This is the offending function, unfortunately I see no way around it without patching the code.

  var closeAd = function (e) {
    try {
      if (!e.screenX || e.originalEvent.isTrusted === false) {
        return;
      }
    } catch (e) {
    }
    if (isEmbedded && !window.open('javascript:close()', '_blank')) {
      window.location = redirectURL + '?from_embed';
      return;
    }
    $('#player_3x2_container').hide();
    $('#aoverlay').hide();
    localStorage[key] = 1;
    /*
    if (!played) {
      player.play();
      $('#close-btn-icon').removeClass('glyphicon-play');
      $('#close-btn-icon').addClass('glyphicon-remove');
      $('#close-btn-text').text(' 閉じる・Close');
      played = true;
    }*/
  };
@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Jul 27, 2018

Yea, it can be patched in Nano Defender, but it'll most likely turn into a cat and mouse game again.
I honestly don't want to bother.

jspenguin2017 commented Jul 27, 2018

Yea, it can be patched in Nano Defender, but it'll most likely turn into a cat and mouse game again.
I honestly don't want to bother.

@ZaphodBeebblebrox

This comment has been minimized.

Show comment
Hide comment
@ZaphodBeebblebrox

ZaphodBeebblebrox Jul 27, 2018

Member

When it comes down to it, that x isn't too annoying. Its not worth fighting over. We could add something like avgle.com###player_3x2_close:style(font-size: 500% !important;) to make it more obvious if its too hard to spot right now.

Member

ZaphodBeebblebrox commented Jul 27, 2018

When it comes down to it, that x isn't too annoying. Its not worth fighting over. We could add something like avgle.com###player_3x2_close:style(font-size: 500% !important;) to make it more obvious if its too hard to spot right now.

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Jul 27, 2018

It's up to you. I don't think the current solution will last long TBH. If I recall correctly, we had a lot of problems with avgle.com in the past.

jspenguin2017 commented Jul 27, 2018

It's up to you. I don't think the current solution will last long TBH. If I recall correctly, we had a lot of problems with avgle.com in the past.

@okiehsch

This comment has been minimized.

Show comment
Hide comment
@okiehsch

okiehsch Jul 27, 2018

Contributor

Yes, the popup can't be blocked in uBO-flters, even adding
avgle.com##script:inject(window.open-defuser.js)
will break the player if you click the x.

@ZaphodBeebblebrox that's a good idea, though 500% seems a bit much
avgle.com###player_3x2_close:style(font-size: 250% !important;) should make it obvious enough,

Contributor

okiehsch commented Jul 27, 2018

Yes, the popup can't be blocked in uBO-flters, even adding
avgle.com##script:inject(window.open-defuser.js)
will break the player if you click the x.

@ZaphodBeebblebrox that's a good idea, though 500% seems a bit much
avgle.com###player_3x2_close:style(font-size: 250% !important;) should make it obvious enough,

ZaphodBeebblebrox added a commit that referenced this issue Jul 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment