New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ads / Anti-adblock] wowescape.com #3200

Closed
jspenguin2017 opened this Issue Aug 12, 2018 · 14 comments

Comments

Projects
None yet
3 participants
@jspenguin2017

jspenguin2017 commented Aug 12, 2018

URL(s) where the issue occurs

http://www.wowescape.com/play/wow-lost-desert-escape/18974

Describe the issue

Anti-adblock

Screenshot(s)

image

Versions

  • Browser/version: Chrome 70
  • uBlock Origin version: 1.16.14

Settings

English default.

@mapx-

This comment has been minimized.

Show comment
Hide comment
@mapx-

mapx- Aug 12, 2018

Contributor
@@||wowescape.com^$generichide
@@||imasdk.googleapis.com/js/sdkloader/ima3.js$script,domain=wowescape.com
@@||pagead2.googlesyndication.com/pagead/$script,domain=wowescape.com
@@||googleads.g.doubleclick.net/pagead/*wowescape.com$xmlhttprequest,domain=imasdk.googleapis.com
@@||youtube.com/get_video?$media,domain=wowescape.com
Contributor

mapx- commented Aug 12, 2018

@@||wowescape.com^$generichide
@@||imasdk.googleapis.com/js/sdkloader/ima3.js$script,domain=wowescape.com
@@||pagead2.googlesyndication.com/pagead/$script,domain=wowescape.com
@@||googleads.g.doubleclick.net/pagead/*wowescape.com$xmlhttprequest,domain=imasdk.googleapis.com
@@||youtube.com/get_video?$media,domain=wowescape.com
@okiehsch

This comment has been minimized.

Show comment
Hide comment
@okiehsch

okiehsch Aug 12, 2018

Contributor

I don't see a better fix without breaking the site.

Contributor

okiehsch commented Aug 12, 2018

I don't see a better fix without breaking the site.

@mapx- mapx- closed this in c92a3d1 Aug 12, 2018

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Aug 14, 2018

Eh... I wouldn't call this fixed.
image

jspenguin2017 commented Aug 14, 2018

Eh... I wouldn't call this fixed.
image

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Aug 14, 2018

Yea, it's kind of hard to fix in uBO. I'll land a rule in ND.

jspenguin2017 commented Aug 14, 2018

Yea, it's kind of hard to fix in uBO. I'll land a rule in ND.

jspenguin2017 added a commit to jspenguin2017/uBlockProtector that referenced this issue Aug 14, 2018

@okiehsch

This comment has been minimized.

Show comment
Hide comment
@okiehsch

okiehsch Aug 14, 2018

Contributor

I did not see those "failed request" blocks yesterday.
wowescape.com##[id^=aswift]
works on my end, I will update the fix.

Contributor

okiehsch commented Aug 14, 2018

I did not see those "failed request" blocks yesterday.
wowescape.com##[id^=aswift]
works on my end, I will update the fix.

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Aug 14, 2018

@okiehsch That doesn't block the video ads:
image

jspenguin2017 commented Aug 14, 2018

@okiehsch That doesn't block the video ads:
image

@okiehsch

This comment has been minimized.

Show comment
Hide comment
@okiehsch

okiehsch Aug 14, 2018

Contributor

I know, I meant the gray blocked request boxes
image

If you can come up with a uBO-compatible filter that blocks the video ads without breaking the "game", I will add it and remove the exceptions.

Contributor

okiehsch commented Aug 14, 2018

I know, I meant the gray blocked request boxes
image

If you can come up with a uBO-compatible filter that blocks the video ads without breaking the "game", I will add it and remove the exceptions.

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Aug 14, 2018

I don't think there's a way to block the ads without patching the inline scripts, which uBO can't do unless @gorhill implements privileged resources.

jspenguin2017 commented Aug 14, 2018

I don't think there's a way to block the ads without patching the inline scripts, which uBO can't do unless @gorhill implements privileged resources.

okiehsch added a commit that referenced this issue Aug 14, 2018

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Aug 14, 2018

@okiehsch Can we reopen this though? It can be fixed, we just need a scriptlet. I think we can come up with something that won't be too dangerous to let other filter maintainers to use.

jspenguin2017 commented Aug 14, 2018

@okiehsch Can we reopen this though? It can be fixed, we just need a scriptlet. I think we can come up with something that won't be too dangerous to let other filter maintainers to use.

@okiehsch okiehsch reopened this Aug 14, 2018

@okiehsch

This comment has been minimized.

Show comment
Hide comment
@okiehsch

okiehsch Aug 14, 2018

Contributor

To make it clear, the anti-adblock issue has been fixed, what has not been fixed, because it would also break site functionality, is the video ads.

Contributor

okiehsch commented Aug 14, 2018

To make it clear, the anti-adblock issue has been fixed, what has not been fixed, because it would also break site functionality, is the video ads.

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Aug 15, 2018

Can we make a surrogate for IMA SDK that just says there's no ads to play? Or ads skipped?

This should be a decent starting point: https://github.com/jspenguin2017/uBlockProtector/blob/master/src/resources/ima3.js

jspenguin2017 commented Aug 15, 2018

Can we make a surrogate for IMA SDK that just says there's no ads to play? Or ads skipped?

This should be a decent starting point: https://github.com/jspenguin2017/uBlockProtector/blob/master/src/resources/ima3.js

@jspenguin2017 jspenguin2017 changed the title from [Anti-adblock] wowescape.com to [Ads / Anti-adblock] wowescape.com Aug 15, 2018

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 Aug 17, 2018

The website updated, I'm not sure if it's working now or it's playing a 9 minutes ads, can someone re-test?

jspenguin2017 commented Aug 17, 2018

The website updated, I'm not sure if it's working now or it's playing a 9 minutes ads, can someone re-test?

@okiehsch

This comment has been minimized.

Show comment
Hide comment
@okiehsch

okiehsch Aug 17, 2018

Contributor

Well, after the 9 minute video nothing happens on my end, so I think it is a creative way to say to all adblock users -- see how the video ends :)

Contributor

okiehsch commented Aug 17, 2018

Well, after the 9 minute video nothing happens on my end, so I think it is a creative way to say to all adblock users -- see how the video ends :)

okiehsch added a commit that referenced this issue Aug 17, 2018

@jspenguin2017

This comment has been minimized.

Show comment
Hide comment
@jspenguin2017

jspenguin2017 commented Aug 19, 2018

Broke.

@okiehsch okiehsch closed this in 82ab841 Aug 19, 2018

okiehsch added a commit that referenced this issue Aug 21, 2018

okiehsch added a commit that referenced this issue Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment