Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dramafever.com #3389

Closed
KonoromiHimaries opened this issue Sep 2, 2018 · 27 comments
Closed

dramafever.com #3389

KonoromiHimaries opened this issue Sep 2, 2018 · 27 comments

Comments

@KonoromiHimaries
Copy link
Contributor

KonoromiHimaries commented Sep 2, 2018

URL(s) where the issue occurs

https://www.dramafever.com/drama/5193/18/are-you-human-too/

Describe the issue

[Be as clear as possible: nobody can read mind, and nobody is looking at your issue over your shoulder.]
yellow dots on the progress bar

Screenshot(s)

2018-09-02-are you human too_ _ episode 18 _ dramafever

Versions

  • Browser/version: [here] chr 68.0.3440.106
  • uBlock Origin version: [here] ubo 1.16.18

Settings

ubo settings

https://gist.github.com/KonoromiHimaries/ce463027dda8ce57b01bb5639009f21e

@uBlock-user
Copy link
Contributor

dramafever.com##.vjs-admarker

@THEtomaso
Copy link

I noticed those things @ YouTube Gaming, a long time ago.

Example:
https://gaming.youtube.com/watch?v=ePI6USOMHec

I took care of them with this rule (which you might want to add too):
youtube.com##.ytp-ad-progress

@mapx-
Copy link
Contributor

mapx- commented Sep 2, 2018

##.ytp-ad-progress is already in easylist

The other annoyance above should go in easylist

@mapx- mapx- closed this as completed Sep 2, 2018
@THEtomaso
Copy link

THEtomaso commented Sep 2, 2018

##.ytp-ad-progress is already in easylist

Yeah, but for some reason it doesn't work for gaming.youtube.com
They need to add youtube.com in front of it.

The other annoyance above should go in easylist

Reported it here (in the second post):
easylist/easylist#1778

@uBlock-user
Copy link
Contributor

Yeah, but for some reason it doesn't work

See if there is a $generichide filter overiding it via the logger.

@THEtomaso
Copy link

I just gave it a try, using EasyList only.
The existing rule doesn't work, and I can't see anything in the logger that should override it.
Weird!

@okiehsch
Copy link
Contributor

okiehsch commented Sep 2, 2018

The existing rule doesn't work

You mean it does not show up in the logger?

@THEtomaso
Copy link

You mean it does not show up in the logger?

That's right.
The only cosmetic rule from EasyList that shows up in the logger is this one:
##.ad-container

@mapx-
Copy link
Contributor

mapx- commented Sep 2, 2018

Try reinstalling uBo and use the default setup.

@okiehsch
Copy link
Contributor

okiehsch commented Sep 2, 2018

unbenannt

works with Chrome and Firefox on my end.

@THEtomaso
Copy link

Try reinstalling uBo and use the default setup.

I just tried with a fresh Pale Moon Portable, using uBO with everything set to default.
That EasyList rule still doesn't work!

It should be noted that I'm using uBO v1.16.4.4 (XUL)
Perhaps there's a bug in this branch that needs to be fixed?

@mapx-
Copy link
Contributor

mapx- commented Sep 2, 2018

I tested right now pale moon + uBo 1.16.4.4, all fine for me.

@THEtomaso
Copy link

I'll double check from my end.

@THEtomaso
Copy link

THEtomaso commented Sep 2, 2018

I've double checked it now.
Fresh browser, fresh uBO legacy, and updated filters with everything set to default..

The rule ##.ytp-ad-progress works just fine at youtube.com, but NOT at gaming.youtube.com!
adding youtube.com in front of it, fixes it right away.
Like this:
youtube.com##.ytp-ad-progress

Test it yourself here:
https://gaming.youtube.com/watch?v=ePI6USOMHec

@mapx-
Copy link
Contributor

mapx- commented Sep 2, 2018

right, on gaming I can reproduce the issue, what do you think @gorhill ? (working fine in chrome, firefox)

edit: refreshed the page I cannot reproduce anymore

@THEtomaso
Copy link

I refreshed the page 10 times just now..
The existing EasyList rule didn't work one single time! :(

@gorhill
Copy link
Member

gorhill commented Sep 2, 2018

what do you think @gorhill

I don't know, I would need to investigate but if only Pale Moon is affected I rather leave the investigation to whoever uses Pale Moon and uBO.

@gwarser
Copy link
Member

gwarser commented Sep 2, 2018

cssOrigin was introduced in 53, I can reproduce in 52.9 ESR

@gorhill
Copy link
Member

gorhill commented Sep 2, 2018

He is using uBO/legacy.

@THEtomaso
Copy link

THEtomaso commented Sep 2, 2018

I've posted a reference in the Pale Moon forum here:
https://forum.palemoon.org/viewtopic.php?f=46&t=20267/

@gorhill
Copy link
Member

gorhill commented Sep 2, 2018

I can't reproduce with Pale Moon 27.6.0, uBO/legacy and youtube.com##.ytp-ad-progress, the yellow dots are not visible.

If I toggle cosmetic filtering (no need to reload the page), I see the yellow dots, they disappear again if enabling back cosmetic filtering. So all work as expected.

@THEtomaso
Copy link

Yeah, but the EasyList rule looks like this: ##.ytp-ad-progress (without youtube.com in front of it).
Like I've already pointed out; this only works at youtube.com, but NOT at gaming.youtube.com.
If I add youtube.com in front of the rule, like this: youtube.com##.ytp-ad-progress, then it works at gaming.youtube.com as well!

@mapx-
Copy link
Contributor

mapx- commented Sep 2, 2018

@gorhill
Copy link
Member

gorhill commented Sep 2, 2018

EasyList rule looks like this: ##.ytp-ad-progress

Then it's probably gorhill/uBlock#1885 (comment). The proper workaround is to create youtube.com##.ytp-ad-progress.

@uBlock-user
Copy link
Contributor

Works fine on the video link @gwarser posted -

@THEtomaso
Copy link

it's probably gorhill/uBlock#1885 (comment).

And this is no longer an issue for the WebExtensions version of uBO?

@gorhill
Copy link
Member

gorhill commented Sep 2, 2018

Still an issue -- maybe the timings are different now such that when uBO process the DOM the class .ytp-ad-progress is already in there. I am just speculating.

But anyways, thinking about it, if this is the issue (which is my best guess), then I will add the filter to uBO filters, there is always the chance it will occur with the webext version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants