Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional links for the assets.json file #197

Closed
DandelionSprout opened this Issue Sep 2, 2018 · 9 comments

Comments

Projects
None yet
3 participants
@DandelionSprout
Copy link

commented Sep 2, 2018

(Long version; a shortened version is available further down in this thread.)

Inspired by #166 (and to some degree DandelionSprout/adfilt#6), I've learned about three things to add to the assets.json file.

  1. In part to try to resolve DandelionSprout/adfilt#6, part to backup my lists in case of problems or GitHub downtime, and part to make use of assets.json's ability to support multiple contentURL links, my Norwegian list now has an official mirror, that could be added to NOR-0's contentURL as a secondary link. It's however not quite that straight-forward:

1-A) http://repo.or.cz is currently implementing an SSH certificate that'd be recognised by major browsers, with the current estimate according to the message on their frontpage being early October 2018, if I understand it correctly. In the meantime, some browsers won't be able to sync the list properly when using the HTTPS version of the https://repo.or.cz link. Therefore the example below has also added the HTTP link as the 3rd link, for the sake of their HTTPS transition period.

 "contentURL": [
		"https://raw.githubusercontent.com/DandelionSprout/adfilt/master/NorwegianList.txt",
		"https://repo.or.cz/FilterMirrorRepo.git/blob_plain/refs/heads/master:/NorwegianList.txt",
                "http://repo.or.cz/FilterMirrorRepo.git/blob_plain/refs/heads/master:/NorwegianList.txt"
		],

1-B) Notably (in a mostly positive way), it is possible to mirror almost any Git on http://repo.or.cz, without requiring any involvement from the original repo's owner. To avoid potential moral concerns, I've chosen to only do that with my own lists. But it could also mean that http://repo.or.cz could become a convenient backup place for some of the smaller lists among the default ones, should you or anyone else with ties to uBO choose to do so.

  1. Regarding the Lithuanian list: During experimentation with Tor Browser, I discovered that Tor Browser doesn't support https://margevicius.lt 's SSH certificate for some reason, at least on my end.

So therefore I suppose that the HTTP version of that list's contentURL would have to be re-added, though as a secondary link this time, so that it becomes

 "contentURL": [
		"https://margevicius.lt/easylistlithuania.txt",
		"http://margevicius.lt/easylistlithuania.txt"
		],
  1. I became aware that there were a few adblock list projects that were from Thailand, a country that have yet to get a list included in uBlock Origin.

Since the existing lists didn't have a sufficiently broad nor specific coverage of Thai websites, I decided to pull some strings to bring together the two largest Thai list projects, into one list that had a broader coverage.

Since the pull was accepted, I hereby propose that EasyList Thailand (https://github.com/easylist-thailand/easylist-thailand/blob/master/subscription/easylist-thailand.txt) can be included in uBlock Origin to serve Thai users of uBO, and to further encourage the creation of adblocker lists around the world.

Edit: Simplified 1. and 3. in light of new developments.

@uBlock-user

This comment has been minimized.

Copy link
Member

commented Sep 2, 2018

Can't decipher what're you trying to say from the wall of text. I take this as you're suggesting to add more links to assets.json ?

@DandelionSprout

This comment has been minimized.

Copy link
Author

commented Sep 2, 2018

Ah, uh, yes. Additional links for the Norwegian and Lithuanian lists, and suggesting the addition of a Thai list, basically.

@DandelionSprout

This comment has been minimized.

Copy link
Author

commented Sep 4, 2018

I am indeed beginning to see that the OP was quite heavily detailed, but I was of the belief that it was better to list all the contexts and circumstances to it, than to simply go "Add these links plz".

If gorhill is pressed on time, which I presume he is, I could distill OP to perhaps half-ish of its current size instead.

@DandelionSprout

This comment has been minimized.

Copy link
Author

commented Sep 4, 2018

(Shortened version:)

Inspired by #166, here's some more links to add to assets.json.

  1. To try to resolve connection issues and GitHub downtimes, my Norwegian list now has a secondary mirror version.

Note 1) The mirror's site is about to implement a broadly accepted SSH certificate in October. In the meantime only the HTTP link will work in most cases. I therefore suggest adding the HTTPS link as the 2nd contentURL link, and the HTTP link as the 3rd.

Note 2) It is also possible to create mirrors on repo.or.cz even without the input of the original repo's owner. I have however only done so for my own repo.

  1. margevicius.lt's SSH certificate is accepted on most browsers, but not on all browsers (e.g. Tor Browser). Therefore the HTTP should be re-added as the 2nd contentURL link for EasyList Lithuania.

  2. I propose the addition of EasyList Thailand to serve Thai users, as there are currently no Thai lists in uBlock Origin, and in light of recent improvements to that list.

@gorhill

This comment has been minimized.

Copy link
Member

commented Sep 5, 2018

I will add EasyList Thailand.

I will not add the two others because

  1. the certificate used by repo.or.cz is being blacklisted, and the list does not load in Tor, Nightly, and Chrome dev build. I will reconsider once the certificate issue is resolved.

  2. The list loaded fine in all browsers on my side, including the Tor browser.

@DandelionSprout

This comment has been minimized.

Copy link
Author

commented Sep 5, 2018

Fair enough. 🙂

I could give you a headsup about repo.or.cz again when their certificate issue has been resolved, which is currently still a month or two away according to them.

@DandelionSprout

This comment has been minimized.

Copy link
Author

commented Oct 4, 2018

@gorhill I can confirm that repo.or.cz have now got their new HTTPS certificate up and running, which means that https://repo.or.cz/FilterMirrorRepo.git/blob_plain/refs/heads/master:/NorwegianList.txt should now work properly at last.

@gorhill

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

Do you prefer the mirror to be tried first or the other way around? uBO always tries to use the first URL listed.

@DandelionSprout

This comment has been minimized.

Copy link
Author

commented Oct 4, 2018

The other way around, since the GitHub version remains my primary repo and is updated slightly faster.

gorhill added a commit to gorhill/uBlock that referenced this issue Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.