Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong Map method used #504

Closed
joey04 opened this issue Apr 2, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@joey04
Copy link

commented Apr 2, 2019

The method in this line should be .size because it's a Map. (Surely you don't want the default length method here.)

Very minor because the default lists contain many $csp rules, so the vast majority of users won't see a difference. (But still worth a simple fix for correctness sake.)

@gorhill

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

Can you open a pull request for this? Pull requests are fine for fixes like this.

@joey04

This comment has been minimized.

Copy link
Author

commented Apr 3, 2019

Sorry, no, I'm not setup with git and such. Plus you have to decide to either replace the method or just remove the line (for the reason I mentioned above).

@uBlock-user uBlock-user changed the title wrong Map method used (very minor) wrong Map method used Apr 3, 2019

@noelleleigh

This comment has been minimized.

Copy link

commented Apr 6, 2019

Made a PR for this: gorhill/uBlock#3755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.