Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmake timestamp function #1334

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@bmwiedemann
Copy link
Contributor

bmwiedemann commented Mar 5, 2019

Use cmake timestamp function:
This makes it simpler, work on more platforms
and allows for reproducible builds.
See https://reproducible-builds.org/ for why this is good.

Without this patch, I got such diffs

/usr/share/man/man1/utox.1.gz
@@ -1,4 +1,4 @@
-.TH UTOX "1" "March 2019" "µTox 0.17.0"
+.TH UTOX "1" "April 2034" "µTox 0.17.0"

This PR was done while working on reproducible builds for openSUSE.


This change is Reviewable

Use cmake timestamp function
This makes it simpler, work on more platforms
and allows for reproducible builds.
See https://reproducible-builds.org/ for why this is good.

@GrayHatter GrayHatter merged commit 55c40ce into uTox:develop Mar 7, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@GrayHatter

This comment has been minimized.

Copy link
Member

GrayHatter commented Mar 7, 2019

Cheers mate, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.