Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Filenames with spaces fail on upload. #3

Closed
wink opened this Issue Oct 1, 2012 · 3 comments

Comments

Projects
None yet
4 participants

wink commented Oct 1, 2012

Uploading a file with a space in its filename returns an error after upload is complete:

$ geturl ~/Documents/insurance\ claim.txt

Uploading the file to Filepicker.io...

################################################################## 100.0%

curl: (6) Could not resolve host: claim.txt; nodename nor servname provided, or not known
Traceback (most recent call last):
File "/usr/local/bin/geturl", line 56, in
{"filename": sys.argv[1], "apikey": APIKEY, "fpurl": FPURL}, shell=True)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 544, in check_output
raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command 'curl --progress-bar -F "fileUpload=@/Users/wink/Documents/insurance claim.txt" -F "apikey=Au2fZ0IXMQguEemJ1bb4_z" https://www.filepicker.io/api/path/storage//Users/wink/Documents/insurance claim.txt' returned non-zero exit status 6

Awesome tool, by the way. +1 on a brew install.

yonson2 commented Oct 1, 2012

I also get errors when uploading files with non-alfanumeric characters, such as [foo]__bar.txt.

Owner

uams commented Oct 2, 2012

Yeah. I should be url encoding.

Contributor

dideler commented Oct 5, 2012

First reference (4c50578) is just this fix on the master branch. Second reference (308e19c) is from a branch where I also made other changes.

@uams uams closed this in 4c50578 Oct 5, 2012

uams added a commit that referenced this issue Oct 5, 2012

Merge pull request #14 from dideler/issue-3
Fixes #3 - support files with whitespace and special chars

joidegn added a commit to joidegn/geturl that referenced this issue Oct 5, 2012

joidegn added a commit to joidegn/geturl that referenced this issue Oct 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment