Restrict username to lowercase and not only number when signing up #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mokey currently allows case-sensitive username when signing-up. However, the
user_addrpc call sanitizes the username and make it all lowercase. The user signing-up is never warned, so it might try to login with the case sensitive version of its username.Furthermore, the homedir value is created in Mokey and is not sanitized by the rpc_call. So when the user logins with its lowercase username, the value of $HOME is wrong, and the user's session starts in /.
This PR proposes to make sure the username is lowercase. I have also added check that the username is not only made of numbers, which is not allowed in FreeIPA.