Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: allow inertia to not panic and kill everything on container death #607

Closed
2 of 3 tasks
bobheadxi opened this issue Mar 17, 2019 · 0 comments · Fixed by #639
Closed
2 of 3 tasks

config: allow inertia to not panic and kill everything on container death #607

bobheadxi opened this issue Mar 17, 2019 · 0 comments · Fixed by #639
Assignees
Labels
:cmd todo: investigate
Milestone

Comments

@bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Mar 17, 2019

As noted by @rwblickhan unknown containers running on the same VPS as inertia can cause unexpected behaviours, notably that Inertia usually cleans up everything if something fails.

I will be putting in a patch for v0.5.x but this will need to be forwardported for the significantly reworked configuration and client that has been done since v0.5.2. A forwardport should have a better implementation - maybe an array of ignored_containers

  • hotfix and release v0.5.3 (PR: #608)
  • forwardport to master for v0.6.x releases (related: #626, pr: #649)
  • come up with a longer-term solution to this maybe? (see: #633, #633 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:cmd todo: investigate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant