Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pre-commit hook #15

Closed
rwblickhan opened this issue Oct 1, 2018 · 1 comment
Closed

Create pre-commit hook #15

rwblickhan opened this issue Oct 1, 2018 · 1 comment
Assignees
@rwblickhan
Labels
theme:tooling Add or change our tooling, builds, or deployment

Comments

@rwblickhan
Copy link
Collaborator

Travis is protecting our main branches but it’s not officially documented what our build is doing, nor is it very convenient to run all those commands locally. So, we should add a build script to run all those commands and have contributors add this as a pre-commit hook, so that we don’t have to run a Travis build to find linting errors.
@rwblickhan rwblickhan self-assigned this Oct 1, 2018
@rwblickhan rwblickhan added the theme:tooling Add or change our tooling, builds, or deployment label Oct 3, 2018
@rwblickhan
Copy link
Collaborator Author

Adding a post-merge hook to update the dependencies (i.e. pipenv sync) might be useful as well.

@rwblickhan rwblickhan mentioned this issue Oct 6, 2018
Merged
rwblickhan added a commit that referenced this issue Oct 11, 2018
@rwblickhan
Merge pull request #35 from ubclaunchpad/rwblickhan/#15-create-precom…
42ad5c9 
…mit-hook

Add pre-commit/post-merge hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwblickhan rwblickhan

Labels
theme:tooling Add or change our tooling, builds, or deployment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwblickhan