Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Commit

Permalink
PartialRange: decompose #compute => #set{Relays,Workers}
Browse files Browse the repository at this point in the history
  • Loading branch information
Joshua T Corbin committed Feb 26, 2016
1 parent e228590 commit 4582f20
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 16 deletions.
21 changes: 8 additions & 13 deletions partial_range.js
Expand Up @@ -67,20 +67,15 @@ function isValid() {
return this.relayIndex >= 0;
};

PartialRange.prototype.compute =
function compute(relays, workers, now) {
if (relays) {
this.relays = relays;
}

if (workers) {
this.workers = workers;
}

if (!relays && !workers) {
return;
}
PartialRange.prototype.setRelays =
function setRelays(relays, now) {
this.relays = relays;
this.pendingCompute = now;
};

PartialRange.prototype.setWorkers =
function setWorkers(workers, now) {
this.workers = workers;
this.pendingCompute = now;
};

Expand Down
5 changes: 3 additions & 2 deletions service-proxy.js
Expand Up @@ -773,7 +773,8 @@ function getPartialRange(serviceName, reason, now) {
self.minPeersPerRelay
);
self.partialRanges[serviceName] = partialRange;
partialRange.compute(relays, workers, now);
partialRange.setRelays(relays, now);
partialRange.setWorkers(workers, now);
}

if (!partialRange.isValid()) {
Expand Down Expand Up @@ -1095,7 +1096,7 @@ function updateServiceChannel(serviceChannel, now) {
if (self.partialAffinityEnabled) {
var partialRange = self.partialRanges[serviceChannel.serviceName];
if (partialRange) {
partialRange.compute(self.relaysFor[serviceChannel.serviceName], null, now);
partialRange.setRelays(self.relaysFor[serviceChannel.serviceName], now);
}
}

Expand Down
3 changes: 2 additions & 1 deletion test/partial-range.js
Expand Up @@ -71,7 +71,8 @@ function buildPartialRanges(state) {
function computePartialRanges(state, assert) {
for (var i = 0; i < state.partialRanges.length; i++) {
var partialRange = state.partialRanges[i];
partialRange.compute(state.relays, state.workers, 1);
partialRange.setRelays(state.relays, 1);
partialRange.setWorkers(state.workers, 1);
partialRange.computeIfNeeded();
assert.ok(
partialRange.isValid(),
Expand Down

0 comments on commit 4582f20

Please sign in to comment.