Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value: place nocmp zero-sized field first #109

merged 1 commit into from Aug 5, 2022


Copy link

@eNV25 eNV25 commented Aug 5, 2022

Before opening your pull request, please make sure that you've:

  • updated the changelog if the change is user-facing;
  • added tests to cover your changes;
  • run the test suite locally (make test); and finally,
  • run the linters locally (make lint).

Lint runs go generate, which changes copyright years. I chose to not add those to keep the diff small.

@eNV25 eNV25 marked this pull request as ready for review Aug 5, 2022
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #109 (57e8e3f) into master (f9aa9cb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #109   +/-   ##
  Coverage   100.00%   100.00%           
  Files           20        20           
  Lines          201       201           
  Hits           201       201           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

abhinav approved these changes Aug 5, 2022
Copy link

@abhinav abhinav left a comment

We originally chose to do this the other way around because of this guidance in our style guide, but I think it's okay to say that nocmp is a special case so this is okay.

@abhinav abhinav merged commit edb52d7 into uber-go:master Aug 5, 2022
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants