Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove locks from graph for simplicity #50

Merged
merged 2 commits into from
May 17, 2017
Merged

Remove locks from graph for simplicity #50

merged 2 commits into from
May 17, 2017

Conversation

anuptalwalkar
Copy link
Contributor

resolves #46

@coveralls
Copy link

coveralls commented May 17, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 88.514% when pulling 9f40fb9 on anup-remove-locks into e794bab on master.

@glibsm
Copy link
Collaborator

glibsm commented May 17, 2017

go test -race still works right? :)

@anuptalwalkar
Copy link
Contributor Author

yep, make also runs test with race.

@coveralls
Copy link

coveralls commented May 17, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 89.068% when pulling 2fc3d75 on anup-remove-locks into bcc2e22 on master.

@glibsm glibsm mentioned this pull request May 17, 2017
Closed
@anuptalwalkar anuptalwalkar merged commit d88cbc9 into master May 17, 2017
@anuptalwalkar anuptalwalkar deleted the anup-remove-locks branch May 17, 2017 23:23
hbdf pushed a commit to hbdf/dig that referenced this pull request Jul 14, 2022
Add go report card and fix reported misspellings (uber-go#50)
e36fff2 
We have an A+, we should show it off.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glibsm glibsm glibsm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop all the locks?
3 participants
@anuptalwalkar @coveralls @glibsm