From 3debc4bffe9f7ad21b406a841f6d930dfb0862b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82?= Date: Wed, 30 Mar 2022 19:32:43 -0700 Subject: [PATCH 1/2] Add a comment on timers on windows Based on #80 --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index cc8c411..8712535 100644 --- a/README.md +++ b/README.md @@ -43,6 +43,10 @@ func main() { - What's the major diff v.s. https://pkg.go.dev/golang.org/x/time/rate? (based on #77) This ratelimiter was meant to have a (1) simple API and (2) minimal overheard. For more complex use-cases [x/time/rate] is a great choice. See [here][redit] for historical context, and [here][bench] for benchmarks (from 2016). + +- Why does example_test.go fail when I run it locally on Windows? (based on #80) + +Windows has some known issues with timers precision. See golang/go#44343. We don't expect to work around it. [cov-img]: https://codecov.io/gh/uber-go/ratelimit/branch/master/graph/badge.svg?token=zhLeUjjrm2 [cov]: https://codecov.io/gh/uber-go/ratelimit From aeba813a0c2600ba21794962bb9ec11284ac6ae1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82?= Date: Wed, 30 Mar 2022 19:33:37 -0700 Subject: [PATCH 2/2] whitespace --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 8712535..7305cbf 100644 --- a/README.md +++ b/README.md @@ -46,7 +46,7 @@ func main() { - Why does example_test.go fail when I run it locally on Windows? (based on #80) -Windows has some known issues with timers precision. See golang/go#44343. We don't expect to work around it. + Windows has some known issues with timers precision. See golang/go#44343. We don't expect to work around it. [cov-img]: https://codecov.io/gh/uber-go/ratelimit/branch/master/graph/badge.svg?token=zhLeUjjrm2 [cov]: https://codecov.io/gh/uber-go/ratelimit