Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct complex encoding in json encoder (#995) #1001

merged 1 commit into from Sep 8, 2021


Copy link

This PR fixes the encoding of complex number by zap's complex encoder. It also adds the necessary test to ensure the sanity of the change.

Fixes: #995

Copy link

CLAassistant commented Sep 8, 2021

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #1001 (3e34b72) into master (d8fd848) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1001   +/-   ##
  Coverage   98.10%   98.10%           
  Files          46       46           
  Lines        2056     2057    +1     
+ Hits         2017     2018    +1     
  Misses         30       30           
  Partials        9        9           
Impacted Files Coverage Δ
zapcore/json_encoder.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fd848...3e34b72. Read the comment docs.

abhinav approved these changes Sep 8, 2021
Copy link

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@abhinav abhinav merged commit 914c4ff into uber-go:master Sep 8, 2021
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Bug: Incorrect encoding of complex numbers
4 participants