Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: Fix float32 encoding and add test #1003

Merged
merged 1 commit into from Sep 8, 2021
Merged

json: Fix float32 encoding and add test #1003

merged 1 commit into from Sep 8, 2021

Conversation

@manjari25
Copy link
Contributor

@manjari25 manjari25 commented Sep 8, 2021

This commit fixes incorrect float32 encoding. A test
case is also added.

Refs:

  • #1002
  • Internal ticket: GO-860
Refs: 
* #1002
* Internal ticket: GO-860
@codecov
Copy link

@codecov codecov bot commented Sep 8, 2021

Codecov Report

Merging #1003 (98d4f19) into master (914c4ff) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   98.10%   98.20%   +0.09%     
==========================================
  Files          46       46              
  Lines        2057     2058       +1     
==========================================
+ Hits         2018     2021       +3     
+ Misses         30       29       -1     
+ Partials        9        8       -1     
Impacted Files Coverage Δ
zapcore/json_encoder.go 100.00% <100.00%> (ø)
zapcore/sampler.go 100.00% <0.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 914c4ff...98d4f19. Read the comment docs.

sywhang
sywhang approved these changes Sep 8, 2021
Copy link
Contributor

@sywhang sywhang left a comment

LGTM

abhinav
abhinav approved these changes Sep 8, 2021
@manjari25 manjari25 merged commit 305c249 into master Sep 8, 2021
8 checks passed
@manjari25 manjari25 deleted the FixBadEncoding branch Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants