Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Go < 1.15 #1028

Merged
merged 2 commits into from Nov 9, 2021
Merged

Drop support for Go < 1.15 #1028

merged 2 commits into from Nov 9, 2021

Conversation

abhinav
Copy link
Contributor

@abhinav abhinav commented Nov 9, 2021

Per our CI, we don't support versions of Go older than 1.15.

The files global_go112 and global_prego112 existed to
support different stack depths for the standard library logger,
which changed going from Go 1.11 to 1.12 (ref #682).
This is no longer necessary; Go 1.11 is old enough that we don't need
to support it.

Go 1.12 is old enough that we don't need to try to support it.
The files global_go112 and global_prego112 existed to
support different stack depths for the standard library logger,
which changed going from Go 1.11 to 1.12.

This is no longer something we need to support because
per our CI configuration, we only support Go 1.15+.

Ref #682
@abhinav abhinav changed the title Drop support for Go < 1.12 Drop support for Go < 1.15 Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1028 (c6029c2) into master (625d01b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1028   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files          47       47           
  Lines        2067     2067           
=======================================
  Hits         2030     2030           
  Misses         29       29           
  Partials        8        8           
Impacted Files Coverage Δ
global.go 96.66% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625d01b...c6029c2. Read the comment docs.

sywhang
sywhang approved these changes Nov 9, 2021
@abhinav abhinav merged commit aea2a50 into master Nov 9, 2021
10 checks passed
@abhinav abhinav deleted the no-go112 branch November 9, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants