Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add *ln variants of methods to the SugaredLogger #1080

Merged

Conversation

zhupeijun
Copy link
Contributor

@zhupeijun zhupeijun commented Apr 11, 2022

Currently zap sugared logger dose not have method like fmt.Println, this PR adding *ln variants of methods to SugaredLogger.

zap.S().Info("a", "b")
zap.S().Infoln("a", "b")
fmt.Println("a", "b")

zap Info output: ab
zap Infoln output: a b
fmt output: a b

Related issue: #889

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1080 (b20afd6) into master (1d435ba) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
+ Coverage   98.30%   98.31%   +0.01%     
==========================================
  Files          49       49              
  Lines        2123     2137      +14     
==========================================
+ Hits         2087     2101      +14     
  Misses         28       28              
  Partials        8        8              
Impacted Files Coverage Δ
sugar.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d435ba...b20afd6. Read the comment docs.

@zhupeijun zhupeijun force-pushed the feature/add_ln_methods_to_sugarlogger branch 2 times, most recently from 59f6c9d to e013d3b Compare Apr 12, 2022
@zhupeijun zhupeijun force-pushed the feature/add_ln_methods_to_sugarlogger branch from e013d3b to 0f22697 Compare Apr 12, 2022
Copy link
Contributor

@abhinav abhinav left a comment

Thanks!

@abhinav abhinav merged commit d38507c into uber-go:master Apr 12, 2022
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants