Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Must docs #1108

merged 1 commit into from Jun 9, 2022

Fix typo in Must docs #1108

merged 1 commit into from Jun 9, 2022


Copy link

Whoops. I introduced this typo. Sorry about that.

abhinav approved these changes Jun 9, 2022
Copy link

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1108 (9082137) into master (e06e09a) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1108      +/-   ##
+ Coverage   98.27%   98.36%   +0.09%     
  Files          49       49              
  Lines        2145     2145              
+ Hits         2108     2110       +2     
+ Misses         28       27       -1     
+ Partials        9        8       -1     
Impacted Files Coverage Δ
logger.go 96.61% <ø> (ø)
zapcore/sampler.go 100.00% <0.00%> (+3.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06e09a...9082137. Read the comment docs.

@sywhang sywhang merged commit 88a8b01 into uber-go:master Jun 9, 2022
6 checks passed
@craigpastro craigpastro deleted the fix-typo branch Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants